Skip to content

Conversation

@benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Jan 27, 2025

GEOPY-1842 - Refactor Params class with BaseData

@github-actions github-actions bot changed the title Geopy 1842 GEOPY-1842: Refactor Params class with BaseData Jan 27, 2025
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 97.82609% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.35%. Comparing base (678e11e) to head (a8462e1).

Files with missing lines Patch % Lines
simpeg_drivers/components/topography.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #133      +/-   ##
===========================================
- Coverage    91.52%   91.35%   -0.17%     
===========================================
  Files           92       92              
  Lines         5366     5172     -194     
  Branches       561      556       -5     
===========================================
- Hits          4911     4725     -186     
+ Misses         320      316       -4     
+ Partials       135      131       -4     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 95.40% <100.00%> (+3.20%) ⬆️
...peg_drivers/components/factories/misfit_factory.py 97.01% <ø> (-0.05%) ⬇️
simpeg_drivers/components/meshes.py 83.62% <ø> (ø)
...ctricals/direct_current/three_dimensions/params.py 100.00% <100.00%> (ø)
...ls/induced_polarization/three_dimensions/params.py 100.00% <100.00%> (ø)
simpeg_drivers/electricals/params.py 97.84% <100.00%> (ø)
...rivers/electromagnetics/frequency_domain/params.py 94.79% <100.00%> (ø)
...peg_drivers/electromagnetics/time_domain/params.py 99.16% <100.00%> (ø)
...drivers/natural_sources/magnetotellurics/params.py 99.54% <100.00%> (ø)
simpeg_drivers/natural_sources/tipper/params.py 99.27% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

domfournier
domfournier previously approved these changes Jan 28, 2025
Copy link
Collaborator

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. See suggestion about grouping the data and uncertainties as component blocks.

Co-authored-by: domfournier <dominiquef@mirageoscience.com>
@domfournier domfournier merged commit c1c1178 into develop Jan 29, 2025
9 checks passed
@domfournier domfournier deleted the GEOPY-1842 branch January 29, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants