-
Notifications
You must be signed in to change notification settings - Fork 2
GEOPY-1842: Refactor Params class with BaseData #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #133 +/- ##
===========================================
- Coverage 91.52% 91.35% -0.17%
===========================================
Files 92 92
Lines 5366 5172 -194
Branches 561 556 -5
===========================================
- Hits 4911 4725 -186
+ Misses 320 316 -4
+ Partials 135 131 -4
|
domfournier
previously approved these changes
Jan 28, 2025
Collaborator
domfournier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. See suggestion about grouping the data and uncertainties as component blocks.
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
…e the driver still pushes forward_only through InversionData which class these.
domfournier
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-1842 - Refactor Params class with BaseData