Skip to content

GEOPY-2556: Break edge case for 1D inversion with negative elevation #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 3 commits into from
Nov 10, 2025
Merged

GEOPY-2556: Break edge case for 1D inversion with negative elevation #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26153bb
Set topo elevation to -inf on global to bypass check
domfournier Nov 1, 2025
3d5e9c0
Allow to pass kwargs to simulation construction
domfournier Nov 1, 2025
49f3999
Merge branch 'develop' into GEOPY-2556
domfournier Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions simpeg_drivers/components/factories/simulation_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,19 +121,17 @@ def assemble_arguments(
survey=None,
mesh=None,
models=None,
**kwargs,
):
if "1d" in self.factory_type:
return ()

return [mesh]

def assemble_keyword_arguments(
self,
survey=None,
mesh=None,
models=None,
):
kwargs = {}
def assemble_keyword_arguments(self, survey=None, mesh=None, models=None, **kwargs):
if not kwargs:
kwargs = {}

kwargs["survey"] = survey
kwargs["max_chunk_size"] = self.params.compute.max_chunk_size
kwargs["store_sensitivities"] = (
Expand Down
1 change: 1 addition & 0 deletions simpeg_drivers/electromagnetics/base_1d_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ def simulation(self):
mesh=self.inversion_mesh.mesh,
models=self.models,
survey=self.inversion_data.survey,
topo=[0, 0, -np.inf], # Bypass check for global simulation
)

self._simulation.mesh = self.inversion_mesh.mesh
Expand Down
Loading