Skip to content

GEOPY-2557: Save sensitivities option ignored (release 4.7) #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebhmg merged 4 commits into from
Nov 17, 2025
Merged

GEOPY-2557: Save sensitivities option ignored (release 4.7) #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa62d91
cherry
domfournier Nov 17, 2025
7c15fef
Augment test
domfournier Nov 1, 2025
ed6e34d
Add test to MT
domfournier Nov 1, 2025
b72fc89
Revert 1D test
domfournier Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions simpeg_drivers/components/factories/directives_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def save_directives(self):
]:
save_directive = getattr(self, directive)
if save_directive is not None:
directives_list.append(getattr(self, directive))
directives_list.append(save_directive)

if (
isinstance(save_directive, directives.SaveDataGeoH5)
Expand Down Expand Up @@ -200,8 +200,10 @@ def save_property_group(self):
@property
def save_sensitivities_directive(self):
""""""
if self._save_sensitivities_directive is None and isinstance(
self.params, BaseInversionOptions
if (
self._save_sensitivities_directive is None
and isinstance(self.params, BaseInversionOptions)
and self.params.directives.save_sensitivities
):
self._save_sensitivities_directive = SaveSensitivitiesGeoh5Factory(
self.params
Expand Down
1 change: 1 addition & 0 deletions tests/run_tests/driver_mt_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ def test_magnetotellurics_run(tmp_path: Path, max_iterations=1, pytest=True):
driver.params.geoh5.h5file, driver.params.out_group.uid
)
output["data"] = orig_zyy_real_1
assert not run_ws.get_entity("Iteration_0_sensitivities")[0]
if pytest:
check_target(output, target_run, tolerance=0.2)
nan_ind = np.isnan(run_ws.get_entity("Iteration_0_model")[0].values)
Expand Down
Loading