Skip to content

GEOPY-2587: Add dip_direction to list of supported variables by plate_sweep #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benk-mira merged 4 commits into from
Nov 27, 2025
Merged

GEOPY-2587: Add dip_direction to list of supported variables by plate_sweep #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24bae47
Add dip_direction forms
domfournier Nov 24, 2025
f80a164
Add forms to uijson
domfournier Nov 24, 2025
84c3717
Merge branch 'develop' into GEOPY-2587
domfournier Nov 25, 2025
9030828
Modify test to check workdir auto-creation
domfournier Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions simpeg_drivers-assets/uijson/plate_sweep.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,26 @@
"label": "number of samples",
"value": 1
},
"dip_direction_start": {
"main": true,
"group": "Dip Dir",
"groupOptional": true,
"enabled": false,
"label": "starting",
"value": 60.0
},
"dip_direction_stop": {
"main": true,
"group": "Dip Dir",
"label": "ending",
"value": 60.0
},
"dip_direction_count": {
"main": true,
"group": "Dip Dir",
"label": "number of samples",
"value": 1
},
"out_group": {
"label": "SimPEGGroup",
"value": "",
Expand Down
3 changes: 3 additions & 0 deletions simpeg_drivers/plate_simulation/sweep/uijson.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,8 @@ class PlateSweepUIJson(BaseUIJson):
dip_start: FloatForm
dip_stop: FloatForm
dip_count: IntegerForm
dip_direction_start: FloatForm
dip_direction_stop: FloatForm
dip_direction_count: IntegerForm
out_group: GroupForm | None
workdir: StringForm | None
6 changes: 3 additions & 3 deletions tests/plate_simulation/runtest/sweep_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
# '
# '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''

import os

from geoh5py import Workspace
from geoh5py.groups import SimPEGGroup
Expand Down Expand Up @@ -72,8 +71,7 @@ def setup_plate_sweep(workspace) -> SimPEGGroup:

def test_sweep(tmp_path):
workdir = tmp_path / "my_workdir"
os.mkdir(workdir)
assert workdir.exists()

with Workspace.create(tmp_path / "test.geoh5") as ws:
plate_simulation = setup_plate_sweep(ws)

Expand All @@ -95,6 +93,8 @@ def test_sweep(tmp_path):
ifile.write_ui_json(name="plate_sweep.ui.json", path=tmp_path)
PlateSweepDriver.start(tmp_path / "plate_sweep.ui.json")

assert workdir.exists()

with Workspace(tmp_path / "test.geoh5"):
ifile = InputFile.read_ui_json(tmp_path / "plate_sweep.ui.json")
ifile.set_data_value("background_count", 3)
Expand Down