Skip to content

GEOPY-2659: MVI: Add small value to reference amplitude if reference are used #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 3 commits into from
Jan 25, 2026
Merged

GEOPY-2659: MVI: Add small value to reference amplitude if reference are used #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5748fc3
Add small constant. Fix issue with lower_bound
domfournier Jan 21, 2026
ff5db6e
Update test
domfournier Jan 21, 2026
8c7db56
Merge branch 'develop' into GEOPY-2659
domfournier Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions simpeg_drivers/components/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ def reference_model(self) -> np.ndarray | None:
self.reference_inclination,
self.reference_declination,
)
ref_model += 1e-8 # To avoid zeroing the angles
ref_model = (field_vecs.T * ref_model).flatten()

return ref_model
Expand Down Expand Up @@ -271,11 +272,11 @@ def lower_bound(self) -> np.ndarray | None:
else:
bound_model = self._lower_bound.model

if (
self.driver.params.inversion_type == "magnetic vector"
and self._upper_bound.model is not None
):
bound_model = -self._upper_bound.model
if self.driver.params.inversion_type == "magnetic vector":
bound_model = None

if self._upper_bound.model is not None:
bound_model = -self._upper_bound.model

if bound_model is None:
lbound = np.full(self.n_active, -np.inf)
Expand Down
14 changes: 6 additions & 8 deletions tests/run_tests/driver_mvi_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from geoh5py.groups.property_group import GroupTypeEnum
from geoh5py.objects import Curve
from geoh5py.workspace import Workspace
from simpeg.utils.mat_utils import cartesian2amplitude_dip_azimuth

from simpeg_drivers.components.factories import DirectivesFactory
from simpeg_drivers.potential_fields import (
Expand Down Expand Up @@ -213,7 +214,7 @@ def test_magnetic_vector_reference(
tmi_uncertainty=5.0,
data_object=components.survey,
starting_model=components.model,
reference_model=1.0,
reference_model=0.0,
reference_inclination=30,
reference_declination=0,
)
Expand All @@ -224,13 +225,10 @@ def test_magnetic_vector_reference(
assert np.all(driver.models.reference_inclination == 30)
assert np.all(driver.models.reference_declination == 0)

np.allclose(
np.kron(
np.r_[0, np.cos(-np.deg2rad(30)), np.sin(-np.deg2rad(30))],
np.ones(driver.models.n_active),
),
driver.models.reference_model,
)
ref_model = driver.models.reference_model
ref_spherical = cartesian2amplitude_dip_azimuth(ref_model.reshape(-1, 3, order="F"))
np.allclose(ref_spherical[0, 1], 30)
np.allclose(ref_spherical[0, 2], 0)


if __name__ == "__main__":
Expand Down
Loading