GEOPY-2683 #338
Open
GEOPY-2683 #338
+645
−486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benk-mira
requested changes
Jan 27, 2026
Contributor
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Just a few small requests
| def assemble_arguments( # pylint: disable=arguments-differ | ||
| self, tiles | ||
| self, | ||
| tiles: dict[list[np.ndarray]], |
Contributor
There was a problem hiding this comment.
Is this a typo? Can you type a dict without specifying the key type?
| """ | ||
| Directive options for inversion. | ||
| :param auto_scale_misfits: Automatically scale misfits of joint inversions. |
Contributor
There was a problem hiding this comment.
remove, and maybe document the alias behaviour under auto_scale_tiles?
| Directive options for inversion. | ||
| :param auto_scale_misfits: Automatically scale misfits of sub objectives. | ||
| :param auto_scale_misfits: Automatically scale misfits of joint inversions. |
Contributor
There was a problem hiding this comment.
Remove and document alias behaviour under auto_scale_tiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.