GEOPY-2618: GEOPY_2618 #339
Open
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #339 +/- ##
========================================
Coverage 91.11% 91.11%
========================================
Files 117 117
Lines 6402 6402
Branches 777 777
========================================
Hits 5833 5833
Misses 379 379
Partials 190 190
🚀 New features to boost your workflow:
|
domfournier
reviewed
Jan 27, 2026
| """ | ||
|
|
||
| model_type: ModelTypeEnum = ModelTypeEnum.conductivity | ||
| model_type: ModelTypeEnum | None = ModelTypeEnum.conductivity |
Collaborator
There was a problem hiding this comment.
Unclear what would happen if the methods are EM or DC, with a model_type=None.
Can we update one of the tests to validate the outcome?
Contributor
Author
There was a problem hiding this comment.
I checked, and the only references to this model_type are checking if model_type == ModelTypeEnum.resistivity so we should be ok, but I'll add a check to one of the tests
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-2618 - Conductivity/Resistivity switcher