Skip to content

Conversation

@dseptem
Copy link

@dseptem dseptem commented May 19, 2019

I'm not really sure about why this fixes the problem, but it does.
Can confirm because I have windows 7 and weird symbols on track names always made me switch back to Python 3.5 soundscrape.

@dseptem dseptem mentioned this pull request May 19, 2019
@dseptem
Copy link
Author

dseptem commented May 19, 2019

Sadly, it seems that my fix is only Python 3.6 compatible...

@dseptem
Copy link
Author

dseptem commented May 19, 2019

Fixed it so it works on previous python versions.
The tests fail not because of my code, but because they already are failing in the original repo.

@SimplicityGuy
Copy link

@dseptem can you try PR #241 and reply back to see if this is fixed. There are a lot of changes in PR #241, including a requirement to move to Python 3.7+. The error you hit here seems to be an issue with earlier versions of Python 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants