Patch to support transactions#38
Open
sandeep06011991 wants to merge 7 commits intoMobilityFirst:masterfrom
Open
Patch to support transactions#38sandeep06011991 wants to merge 7 commits intoMobilityFirst:masterfrom
sandeep06011991 wants to merge 7 commits intoMobilityFirst:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of DistTransactor being a wrapper around PRC.
I have used DistTransactor to be a callback for the PRC.
We where partially using this in the preExecute case.
This patch treats the DistTransactor as a callback and nothing else.
Some modifications needed where
This solves the problem of the PaxosManager trying to recover before the callback is set.