clean out of warnings ;)

[rakion99]

No description provided.

[LexManos]

IIRC the reason this wasn't done is because it breaks backwards compatibility with older ASM libraries for no particular reason. Yes we compile against 5+ but IIRC we can run with 4+ for people who don't care about J8

[rakion99]

oh ya i forgot about people still using J7

[Pokechu22]

Is that still a problem now that Minecraft 1.12 requires Java 8?

[jamierocks]

You forget that LaunchWrapper is not tied to the latest version of Minecraft, and others may want to mod older versions of Minecraft, using latest LaunchWrapper, without J8 (I can't say why they'd want to, but I guess that's why).

[Pokechu22]

Hm, yeah, I don't exactly know the version scheme that's used for LaunchWrapper. I don't personally see the issue with just saying "all versions after this one will require Java 8", but I don't know how often the version is bumped for this project either.

[LexManos]

Honestly, I would only ever condone bumping required java version for a legitimate functional reason.
Cleaning some dev time warnings is not a legitimate functional reason. So it'll have to be justified a different way.
If people care about them they can toss a @SuppressWarnings on it.

[Hallowizer]

These changes look great!