Skip to content

fix(a11y): prevent double screen reader announcements #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daiverd merged 2 commits into from
Feb 22, 2026
Merged

fix(a11y): prevent double screen reader announcements #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6420b59
fix(a11y): prevent double screen reader announcements in output log
Feb 22, 2026
2ff6384
fix(a11y): prevent double announce on arrow key navigation
Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions src/components/output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,25 +598,27 @@ scrollToBottom = () => { const output = this.outputRef.current; if (output) {
if (visibleOutput.length === 0) return;

switch (e.key) {
case 'ArrowDown':
case 'ArrowDown': {
e.preventDefault();
this.setState(prevState => {
const currentIndex = prevState.focusedLineIndex ?? -1;
const nextIndex = Math.min(currentIndex + 1, visibleOutput.length - 1);
const currentIndex = this.state.focusedLineIndex ?? -1;
const nextIndex = Math.min(currentIndex + 1, visibleOutput.length - 1);
this.setState({ focusedLineIndex: nextIndex }, () => {
this.announceOutputLine(visibleOutput[nextIndex]);
return { focusedLineIndex: nextIndex };
}, this.scrollFocusedLineIntoView);
this.scrollFocusedLineIntoView();
});
break;
}

case 'ArrowUp':
case 'ArrowUp': {
e.preventDefault();
this.setState(prevState => {
const currentIndex = prevState.focusedLineIndex ?? visibleOutput.length;
const prevIndex = Math.max(currentIndex - 1, 0);
const currentIndex = this.state.focusedLineIndex ?? visibleOutput.length;
const prevIndex = Math.max(currentIndex - 1, 0);
this.setState({ focusedLineIndex: prevIndex }, () => {
this.announceOutputLine(visibleOutput[prevIndex]);
return { focusedLineIndex: prevIndex };
}, this.scrollFocusedLineIntoView);
this.scrollFocusedLineIntoView();
});
break;
}

case 'Home':
e.preventDefault();
Expand Down Expand Up @@ -700,10 +702,7 @@ scrollToBottom = () => { const output = this.outputRef.current; if (output) {
onFocus={this.handleOutputFocus}
onBlur={this.handleOutputBlur}
tabIndex={0}
role="log"
aria-label="Game output log - use arrow keys to navigate"
aria-live="polite"
aria-atomic="false"
>
{visibleOutput.map((line, index) => (
<div
Expand Down