Skip to content

refactor: clean up exception.py - add __all__ and remove redundant pass statements#1129

Open
Atman36 wants to merge 1 commit intoMoonshotAI:mainfrom
Atman36:refactor/exception-module-cleanup
Open

refactor: clean up exception.py - add __all__ and remove redundant pass statements#1129
Atman36 wants to merge 1 commit intoMoonshotAI:mainfrom
Atman36:refactor/exception-module-cleanup

Conversation

@Atman36
Copy link

@Atman36 Atman36 commented Feb 13, 2026

What

  • Added __all__ declaration to explicitly export the 7 public exception classes
  • Removed redundant pass statements from all exception class bodies (unnecessary after docstrings)

Why

  • __all__ improves API clarity and enables from kimi_cli.exception import * to work correctly
  • Removing unnecessary pass statements reduces visual noise and follows Python best practices
  • No functional changes — purely code quality improvements

How to verify

# Syntax check
python3 -m py_compile src/kimi_cli/exception.py

# Verify __all__ is correct
python3 -c "from kimi_cli.exception import __all__; print(__all__)"

Notes

  • Breaking change: No
  • Risk: Low
  • Files changed: 1

PR prepared with AI assistance (Claude Code PR Factory)


Open with Devin

…ss statements

- Added __all__ declaration to explicitly export the 7 public exception classes
- Removed redundant pass statements from all exception class bodies
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant