fix: handle broken symlinks gracefully in directory listing#1200
Open
xiaoju111a wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix: handle broken symlinks gracefully in directory listing#1200xiaoju111a wants to merge 1 commit intoMoonshotAI:mainfrom
xiaoju111a wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
Fixes MoonshotAI#1194 - Add explicit symlink detection before calling stat() - Skip broken or inaccessible symlinks instead of crashing - Wrap directory iteration in try-except to handle permission errors - Resolve symlinks with strict=True to detect broken links early This prevents FileNotFoundError when listing directories containing: - Broken symlinks (pointing to non-existent targets) - Circular symlinks (loop1 -> loop2 -> loop1) - Inaccessible symlinks (permission denied) The fix ensures users can still see other files in the directory even when some symlinks are broken, improving robustness for Laravel projects and other codebases that use symlinks extensively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1194
Problem
When using
@somethingto reference directories containing broken symlinks (common in Laravel projects), the API crashes withFileNotFoundError, preventing users from viewing any files.Solution
stat()This prevents crashes when encountering:
Testing
Created test environment with various symlink types:
Unit tests:
6 passed, 1 warning in 0.04sImpact
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.