-
Notifications
You must be signed in to change notification settings - Fork 694
[fix] kimi_cli failed to find CHANGELOG.md #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ClSlaid
wants to merge
4
commits into
MoonshotAI:main
Choose a base branch
from
ClSlaid:fix/lazy-changelog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−23
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,6 +103,17 @@ def format_release_notes(changelog: dict[str, ReleaseEntry], include_lib_changes | |
| return "\n".join(parts).strip() | ||
|
|
||
|
|
||
| CHANGELOG = parse_changelog( | ||
| (Path(__file__).parent.parent / "CHANGELOG.md").read_text(encoding="utf-8") | ||
| ) | ||
| _cached_changelog: dict[str, ReleaseEntry] | None = None | ||
|
|
||
|
|
||
| def get_changelog() -> dict[str, ReleaseEntry]: | ||
| """Lazily load and parse the changelog on first access.""" | ||
| global _cached_changelog | ||
| if _cached_changelog is None: | ||
| path = Path(__file__).parent.parent / "CHANGELOG.md" | ||
| try: | ||
| _cached_changelog = parse_changelog( | ||
| path.read_text(encoding="utf-8")) | ||
| except FileNotFoundError: | ||
| _cached_changelog = {} | ||
| return _cached_changelog | ||
|
Comment on lines
+109
to
+119
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 v1.7.0 changelog entry replaced with duplicate of v1.6 entry
In
CHANGELOG.md, the v1.7.0 entryWeb: Fix WebSocket errors during history replay by checking connection state before sendingwas replaced withWeb: Fix WebSocket disconnect when creating new sessions. However, that exact same text already exists in the v1.6 section at line 133. This means v1.7.0 now has a duplicate of the v1.6 fix note, and the original v1.7.0 fix description (which described a different bug fix — checking connection state before sending during history replay) is lost. The same duplication occurs indocs/en/release-notes/changelog.mdat line 118 vs line 127.Was this helpful? React with 👍 or 👎 to provide feedback.