fix(agent-core): dispose session terminal records on close#1277
Open
morluto wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 62cf523 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This is a focused follow-up to #1276 for one session-owned resource type.
Problem
Terminal records are session-scoped resources: each record holds a backend terminal process, output listeners, attached sinks, and buffered output.
Today,
TerminalServicecreates those records for a session but does not subscribe toISessionService.onDidClose. As a result, when a session is closed while the service remains alive, terminal records for that session can remain in memory until the whole service is disposed.This breaks the expected ownership model and can leak memory: closing a session should release resources owned by that session.
Code-path proof:
TerminalService.create()stores each terminal inrecords.recordsentries hold the process, output listeners, sinks, and output buffer.TerminalServiceremoves records during whole-service disposal, but did not respond to session close events.ISessionServiceexposesonDidClose, butTerminalServicedid not subscribe to it.This is separate from TUI terminal restoration in #1272. This change concerns agent-core terminal records owned by server sessions.
What changed
TerminalServicenow subscribes toISessionService.onDidCloseand releases terminal records for the closed session.For each matching terminal record, the cleanup path:
A focused regression test covers the session-close behavior through the public terminal service seam.
Validation
pnpm --filter @moonshot-ai/agent-core exec vitest run test/services/terminal-service.test.tspasses: 1 file, 8 tests.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.