fix(agent-core): release filesystem watchers on session close#1279
Open
morluto wants to merge 1 commit into
Open
fix(agent-core): release filesystem watchers on session close#1279morluto wants to merge 1 commit into
morluto wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 187e78e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This is a focused follow-up to #1276 for one session-owned resource type.
Problem
Filesystem watchers are session-scoped resources. Each session watcher owns path references, connection/session reference maps, pending change buffers, debounce timers, and an underlying chokidar watcher.
Today,
FsWatcherServicecan create watcher state for a session, but it does not release that state whenISessionService.onDidClosefires. As a result, when a session closes while the service remains alive, watcher state for that session can remain until paths are explicitly removed or the whole service is disposed.This breaks the expected ownership model: closing a session should release resources owned by that session.
Code-path proof:
FsWatcherService.addPaths()creates or reuses aSessionEntryinsessions.SessionEntryowns path references, connection references, pending change state, timers, and a chokidar watcher.FsWatcherService.removePaths()and service disposal clean entries, but session close did not clean entries.ISessionServiceexposesonDidClose, butFsWatcherServicedid not subscribe to it.What changed
FsWatcherServicenow subscribes toISessionService.onDidCloseand disposes watcher state for the closed session.The cleanup removes the session from each connection map, drops empty connection maps, and disposes the session watcher entry.
A focused regression test verifies that closing a session releases the watcher, clears watched paths for each connection, and resets connection path counts.
Validation
pnpm --filter @moonshot-ai/server exec vitest run test/services.test.tspasses: 1 file, 22 tests.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.