-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Split apk merging #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please rebase off dev branch and resolve conflicts. There has been a few changes on dev that are not on main yet. |
|
This may need a small tweak, or maybe this specific app isn't working right with ARSCLib. This app has issues with AntiSplit-M as well:
If I run the same apkm thru APKEditor it then works with with CLI patching: |
|
Did I do it properly. Or did I mess up. This is the first time I am rebasing anything |
|
Yes this looks right. If that MyFitness app can be figured out it would be good, but at a minimum only Reddit needs to work for this to be merged. |
|
will check both |
I just tried to run morphe-cli with this app along with the 1.9.0 patch.mpp file (assuming we are running ARSCLib so that would throw an issue) but it seems like the app was patched fine. Gradle built successfully. I even got the temp merged apk. If there was an error merging here, it should have thrown an error right? |
|
If I first ran the apkm thru APKEditor, then patching/installing worked with the apk file. But if I tried patching and installing ( |
|
ah, I will have to check this |
|
Wait, there are some issues with my method. Don't merge this yet. I'll have to further test it. |
|
Currently there are issues with my method. I'll need to further test this. Will rework this. |
|
See the commit for URV that I previously mentioned. It uses APKEditor and works for this fitness app without issues. |
|
Yup, will look into it |
|
Yup, things work with APKEditor, when I pull the jar to make it work. Is that the way ahead? |
|
Apkeditor uses ARSCLib, and is made by the same developers. Try looking what apkeditor is doing with ARS and if it's simple then maybe the same can be done here. If it's complicated, then pull in apkeditor and use it. |
|
sure thing |
|
Just by skimming thorough stuff with AI it seems like ARSC does like half the work. The other half of the merging work is done by a bunch of other packages that APKEditor also includes. Looks like adding the jar file as a dependency is the only option for now. I maybe be wrong on this but this is what I could find. Do I use this method and reopen the PR? |
|
Ok if sounds like apkeditor jar should be used. See whatever apkeditor is doing in it's main method and it might be just a few lines of code to do the same. Or if that's undesirable and there's a way to turn off it's console output then could call it's main method using a string command You can reopen this PR. If it won't let you then make a new PR. |
|
I usually add According to APKEditor |
Automatically checks the file extension to see if it's apk or a split apkm. Incase it is split, automatically merges it and prepares an apk for patching.