Migrate from Carthage to Swift Package Manager#204
Open
chxbca wants to merge 2 commits into
Open
Conversation
- Replace Carthage with SPM for dependency management - Integrate MASShortcut as local framework (no SPM support) - Update to Settings 3.x API (renamed from Preferences) - Fix deprecated NSEventModifierFlag constants in MASShortcut - Bump deployment target to macOS 10.15 (required by Defaults 7.x) - Update swiftgen path for Apple Silicon - Remove Carthage files and bootstrap script
- Rename 'preferences' to 'panes' for consistency with Settings API - Rename 'preferencesWindowController' to 'settingsWindowController' - Extract showGeneralSettings() method to reduce duplication - Remove repeated preferencesWindowController.show(pane:) calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR migrates the project from Carthage to Swift Package Manager (SPM) for better dependency management and Apple Silicon support.
Key Changes
Dependency Management: Replaced Carthage with SPM for all dependencies
MASShortcut Integration: Integrated as a local framework (no SPM support available)
API Updates: Updated to Settings 3.x API
PreferencePane→SettingsPanePreferencesWindowController→SettingsWindowControllerDeployment Target: Bumped to macOS 10.15 (required by Defaults 7.x)
Build Configuration: Updated swiftgen path for Apple Silicon compatibility
Testing
Documentation
Added
MIGRATION.mdwith detailed migration notes andAPPLE_SILICON_SUPPORT.mdfor Apple Silicon specific information.Closes #XXX (if there's a related issue)