Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ After you're finished please remove all the comments and instructions!

> This project is application project about movie description user of application can like and leave comments

**[Movie Api]** is a javascript project
**[Movie Api]** is a javascript project that fetches TV Show Data from an API

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MosDevx
Good job so far!

To Highlight! 👏 🟢

  • Good commit messages,
  • Great folder structure
  • Clean code
  • Good PR description
  • Your project is running free of Linter errors

There is some issue that you still need to work on but you are almost there!

Required Changes ♻️
Kindly add the link of live demo on your READEME file

## 🛠 Built With <a name="built-with"></a>

Expand All @@ -81,7 +81,6 @@ After you're finished please remove all the comments and instructions!

## 💻 Getting Started <a name="getting-started"></a>


To get a local copy up and running, follow these steps.

### Prerequisites
Expand All @@ -96,33 +95,38 @@ npm

Clone this repository to your desired folder:

``` git clone https://github.com/MosDevx/MovieApiProject.git```
` git clone https://github.com/MosDevx/MovieApiProject.git`

### Install

Install this project with:

``` npm install ```
`npm install`

### Usage

To run the project, execute the following command:

```npm run serve ```
`npm run serve `

### Run tests

To run tests, run the following command:


```
npm run test
```

### Deployment

You can deploy this project using:
```npm run serve```
`npm run serve`

<!-- LIVE DEMO -->

## 🚀 Live Demo <a name="live-demo"></a>

- [Live Demo Link](https://mosdevx.github.io/MovieApiProject)

<p align="right">(<a href="#readme-top">back to top</a>)</p>

Expand All @@ -138,7 +142,6 @@ You can deploy this project using:
- Twitter: [@moseswamae7](https://twitter.com/moseswamae7)
- LinkedIn: [LinkedIn](https://linkedin.com/in/moses-wamae-a13a67244)


👤 **Aster Alemu**

- GitHub: [@aster-alemu](https://github.com/aster-alemu)
Expand All @@ -147,8 +150,6 @@ You can deploy this project using:

<p align="right">(<a href="#readme-top">back to top</a>)</p>

<p align="right">(<a href="#readme-top">back to top</a>)</p>

<!-- CONTRIBUTING -->

## 🤝 Contributing <a name="contributing"></a>
Expand All @@ -173,8 +174,6 @@ We would like to thank Microverse

<p align="right">(<a href="#readme-top">back to top</a>)</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MosDevx
Good job so far!

To Highlight! 👏 🟢

Good commit messages,
Great folder structure
Clean code
Good PR description
Your project is running free of Linter errors
There is some issue that you still need to work on but you are almost there!

Required Changes ♻️

  • Kindly remove the same element descriptions on your README file
  • Kindly add the link of your project live demo


<p align="right">(<a href="#readme-top">back to top</a>)</p>

<!-- LICENSE -->

## 📝 License <a name="license"></a>
Expand Down
Binary file added dist/3a1926a3547db7d195be.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added dist/c0f59bc5687dc177042b.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 6 additions & 2 deletions dist/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="">
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Magra:wght@400;700&family=Metamorphous&display=swap" rel="stylesheet">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Mukta+Malar:wght@400;700&family=Tenor+Sans&display=swap" rel="stylesheet">
<script src="https://kit.fontawesome.com/dad56601c0.js" crossorigin="anonymous"></script>
<link rel="apple-touch-icon" sizes="57x57" href="/src/assets/favicon/apple-icon-57x57.png">
<link rel="apple-touch-icon" sizes="60x60" href="/src/assets/favicon/apple-icon-60x60.png">
Expand Down Expand Up @@ -54,6 +54,10 @@
</header>


<h1 class="page-title">Todays Tv Shows</h1>

<section id="popup-section"> </section>

<section class="main-section" id="main-section">


Expand Down
88 changes: 84 additions & 4 deletions dist/main.js

Large diffs are not rendered by default.

Loading