Skip to content

Fix OnComponentNotify node not using identity tag match type #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SilentGodot wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

Fix OnComponentNotify node not using identity tag match type #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Source/Flow/Private/Nodes/Actor/FlowNode_OnNotifyFromActor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,24 @@ void UFlowNode_OnNotifyFromActor::ForgetActor(TWeakObjectPtr<AActor> Actor, TWea

void UFlowNode_OnNotifyFromActor::OnNotifyFromComponent(UFlowComponent* Component, const FGameplayTag& Tag)
{
if (Component->IdentityTags.HasAnyExact(IdentityTags) && (!NotifyTags.IsValid() || NotifyTags.HasTagExact(Tag)))
bool IdentityMatches = false;

switch (IdentityMatchType) {
case EFlowTagContainerMatchType::HasAny:
IdentityMatches = Component->IdentityTags.HasAny(IdentityTags);
break;
case EFlowTagContainerMatchType::HasAnyExact:
IdentityMatches = Component->IdentityTags.HasAnyExact(IdentityTags);
break;
case EFlowTagContainerMatchType::HasAll:
IdentityMatches = Component->IdentityTags.HasAll(IdentityTags);
break;
case EFlowTagContainerMatchType::HasAllExact:
IdentityMatches = Component->IdentityTags.HasAllExact(IdentityTags);
break;
}

if (IdentityMatches && (!NotifyTags.IsValid() || NotifyTags.HasTagExact(Tag)))
{
OnEventReceived();
}
Expand Down