Skip to content

Added option to tone down on-screen error messages #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregorhcs wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

Added option to tone down on-screen error messages #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Flow/Private/FlowComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ void UFlowComponent::LogError(FString Message, const EFlowOnScreenMessageType On
}
}
}
else
else if (OnScreenMessageType == EFlowOnScreenMessageType::Temporary)
{
GEngine->AddOnScreenDebugMessage(-1, 2.0f, FColor::Red, Message);
}
Expand Down
3 changes: 2 additions & 1 deletion Source/Flow/Private/Nodes/FlowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,8 @@ void UFlowNode::TriggerOutput(const FName PinName, const bool bFinish /*= false*
if (HasFinished())
{
// do not trigger output if node is already finished or aborted
LogError(TEXT("Trying to TriggerOutput after finished or aborted"));
LogError(TEXT("Trying to TriggerOutput after finished or aborted"),
GetDefault<UFlowSettings>()->FinishedNodeTriggerErrorLogScreenPersistency);
return;
}

Expand Down
2 changes: 1 addition & 1 deletion Source/Flow/Private/Nodes/FlowNodeBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ void UFlowNodeBase::LogError(FString Message, const EFlowOnScreenMessageType OnS
}
}
}
else
else if (OnScreenMessageType == EFlowOnScreenMessageType::Temporary)
{
GEngine->AddOnScreenDebugMessage(-1, 2.0f, FColor::Red, Message);
}
Expand Down
6 changes: 6 additions & 0 deletions Source/Flow/Public/FlowSettings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#pragma once

#include "FlowTypes.h"
#include "Engine/DeveloperSettings.h"
#include "Templates/SubclassOf.h"
#include "UObject/SoftObjectPath.h"
Expand Down Expand Up @@ -43,6 +44,11 @@ class FLOW_API UFlowSettings : public UDeveloperSettings
// by incorporating data that would otherwise go in the Description
UPROPERTY(EditAnywhere, config, Category = "Nodes")
bool bUseAdaptiveNodeTitles;

// On screen message type for runtime errors when a flow node
// is attempted to be triggered after being finished or aborted.
UPROPERTY(EditAnywhere, config, Category = "Nodes")
EFlowOnScreenMessageType FinishedNodeTriggerErrorLogScreenPersistency = EFlowOnScreenMessageType::Permanent;

#if WITH_EDITOR
DECLARE_DELEGATE(FFlowSettingsEvent);
Expand Down
3 changes: 2 additions & 1 deletion Source/Flow/Public/FlowTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ UENUM(BlueprintType)
enum class EFlowOnScreenMessageType : uint8
{
Temporary,
Permanent
Permanent,
Disabled
};

UENUM(BlueprintType)
Expand Down