Skip to content

DEV-1124: upload to a folder#58

Merged
AivanF merged 1 commit intomainfrom
aivan/dev-1124-re-importing-masters
Feb 27, 2026
Merged

DEV-1124: upload to a folder#58
AivanF merged 1 commit intomainfrom
aivan/dev-1124-re-importing-masters

Conversation

@AivanF
Copy link
Contributor

@AivanF AivanF commented Feb 24, 2026

Summary by CodeRabbit

  • New Features
    • Improved image upload workflow with the ability to specify a target Google Drive folder for uploaded images
    • Enhanced support for Google Shared Drives, enabling image upload and management features to work across all Drive storage types and configurations

@AivanF AivanF requested a review from whimo February 24, 2026 14:00
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

📝 Walkthrough

Walkthrough

Added optional folder_id parameter to upload_image_to_drive() method to support uploading images to specific Drive folders. Updated Drive API calls to include supportsAllDrives=True for Shared Drives compatibility. Minor formatting adjustments applied.

Changes

Cohort / File(s) Summary
Drive Upload and Shared Drives Support
gslides_api/client.py
Added optional folder_id parameter to upload_image_to_drive() method; updated Drive API calls with supportsAllDrives=True flag to enable Shared Drives support; adjusted formatting on multi-line statements and error messages.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Through folders deep in Drive so vast,
We hop with images held so fast,
Shared Drives now welcome our uploads bright,
With folder_id guiding left and right,
A rabbit's code hops on with might! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 35.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: adding folder_id parameter to upload_image_to_drive() to enable uploading images to a specific folder.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aivan/dev-1124-re-importing-masters

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@gslides_api/client.py`:
- Around line 224-226: Replace the inline RuntimeError with a dedicated custom
exception class (e.g., ChildClientFromUninitializedParentError) defined in this
module (or an exceptions module) that carries the default message "Cannot create
child client from uninitialized parent client"; update the raise site (the code
that currently does raise RuntimeError(...)) to raise
ChildClientFromUninitializedParentError instead, and export/import the new
exception where needed so lint (RUF003) no longer flags the long inline message.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbb4585 and e74e9c7.

📒 Files selected for processing (1)
  • gslides_api/client.py

@AivanF AivanF merged commit 947f0b8 into main Feb 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants