Enable more ruff#1169
Merged
Merged
Conversation
This set of rules will help maintain a high standard of code quality and act as guardrails for LLMs.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1169 +/- ##
=======================================
Coverage 63.33% 63.33%
=======================================
Files 177 177
Lines 12186 12176 -10
Branches 551 551
=======================================
- Hits 7718 7712 -6
+ Misses 4434 4430 -4
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jschwartzentruber
approved these changes
May 5, 2026
Contributor
jschwartzentruber
left a comment
jschwartzentruber
left a comment
There was a problem hiding this comment.
lgtm besides suggestions
| # Now clean the signature directory, only deleting signatures and metadata | ||
| for sigFile in os.listdir(self.sigCacheDir): | ||
| if sigFile.endswith(".signature") or sigFile.endswith(".metadata"): | ||
| if sigFile.endswith((".signature", ".metadata")): |
Contributor
There was a problem hiding this comment.
TIL .. this should all be pathlib, but that's another problem
| elif isARM64(): | ||
| # ARM64 has GPRs from x0 to x30 | ||
| regs = ["x" + str(x) for x in range(0, 31)] | ||
| regs = ["x" + str(x) for x in range(31)] |
Contributor
There was a problem hiding this comment.
I know this is all auto-fixes, but this should be an f-string (here and in RegisterHelper)
Contributor
Author
There was a problem hiding this comment.
Yes there are a lot of potential f-string fixes. They can be addressed in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of rules will help maintain a high standard of code quality and act as guardrails for LLMs.