Fix NPE getting range on NeoForge platform#139
Open
PersonTheCat wants to merge 7 commits intoMrCrayfish:multiloader/1.20.6from
Open
Fix NPE getting range on NeoForge platform#139PersonTheCat wants to merge 7 commits intoMrCrayfish:multiloader/1.20.6from
PersonTheCat wants to merge 7 commits intoMrCrayfish:multiloader/1.20.6from
Conversation
Author
|
I am currently still testing these changes and a second fix which will follow in a different PR. Will need a little more time to confirm. |
Author
|
Confirmed fix in original project and added test coverage for both platforms. Please review. |
Owner
|
Thanks for this, however the code is trying to accomplish more than the PR is describing. If this can be refactored to only be a fix for the NPE when getting the range, I can merge. |
Author
|
@MrCrayfish I removed changes to the build configuration and dependency upgrades. Edit: Just wanna add that I am not able to build without these changes, but this does simplify the diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes tolerate config values with custom predicates on the NeoForge platform. Previously, this would have thrown a NullPointerException.