Fix crash parsing list entries#140
Open
PersonTheCat wants to merge 3 commits intoMrCrayfish:multiloader/1.20.6from
Open
Fix crash parsing list entries#140PersonTheCat wants to merge 3 commits intoMrCrayfish:multiloader/1.20.6from
PersonTheCat wants to merge 3 commits intoMrCrayfish:multiloader/1.20.6from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes resolve a crash when adding list entries due to NumberFormatExceptions (and other errors). I have chosen to resolve this by wrapping all parser functions with an error handler, guaranteeing that a crash can never occur, even with custom parsers. You may disagree with this or the choice to log suppressed exceptions, but I am open to feedback.
Confirmed fix in original project. No test coverage was needed (existing tests were failing)