fix: don't cache partial model downloads as valid files - #46
Closed
btfcookies wants to merge 1 commit into
Closed
Conversation
Both the pose-landmarker download and the FSRCNN upscaler download wrote straight to the final path with urlretrieve. An interrupted download left a truncated file that the exists()/is_file() fast-path then accepted as a valid model on every subsequent run — the server never re-downloaded and model loading failed permanently. Download to a .tmp file and atomically rename into place only on success; clean up the temp file on failure. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
Merged manually (squash) — thanks for the fix! Your original commit is preserved above. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the pose-landmarker download and the FSRCNN upscaler download wrote straight to the final path with urlretrieve. An interrupted download left a truncated file that the exists()/is_file() fast-path then accepted as a valid model on every subsequent run — the server never re-downloaded and model loading failed permanently. Download to a .tmp file and atomically rename into place only on success; clean up the temp file on failure.