Add TSAN+UBSAN and ASAN+UBSAN sanitizer CI jobs and migrate CI asset downloads to OneDrive - #945
Open
Akilan-Sivakumar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prep-assetsfrom downloading CI assets off GitHub release assets to downloading them from OneDrive (via Azure OIDC + Graph API).Changes
New sanitizer jobs
build-tsan/build-asan: build x265 with sanitizer flags across gcc/clang × 8bit/10bit, and verify the binary is actually instrumented.test-tsan/test-asan: run each binary against a set of test clips and fail if any sanitizer issue is detected.if: github.event_name == 'pull_request_target'), same as the existing smoke test jobs.final-statusnow includes these in its merge-gate checks.Asset source change
prep-assetsnow logs in via Azure OIDC and pulls smoke-test assets and the new sanitizer video bundle from OneDrive instead of GitHub release assets.id-token: writepermission (needed for OIDC) and bumped the job timeout to 30 min for the extra download.Security note
id-token: writepermission and Azure credentials (AZURE_CLIENT_ID/AZURE_TENANT_ID) are scoped to theprep-assetsjob only - no other job has access to them.prep-assetsdoes not check out any PR code, so there's no path for a malicious PR to influence this job or exfiltrate the OIDC token via untrusted code execution.