DEV-344 #33
Open
DEV-344 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tu-S
reviewed
Feb 18, 2025
Contributor
Tu-S
left a comment
Tu-S
left a comment
There was a problem hiding this comment.
В идеале бы еще тесты написать на MultiFactorApiClient.
Например
- N урлов недоступны - получаем null в ответ
- Один из N урлов доступен - получаем ответ от апихи. Необязательно нужно получать положительный ответ. Нужно проверить именно факт доступа.
Кмк, проблема будет с созданием экземпляра класса и моком всего лишнего. Так что это на усмотрение Леши
apashkov-ext
requested changes
Feb 18, 2025
apashkov-ext
requested changes
Feb 18, 2025
apashkov-ext
requested changes
Feb 24, 2025
Collaborator
apashkov-ext
left a comment
apashkov-ext
left a comment
There was a problem hiding this comment.
В логах не использовать интерполяцию.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.