Conversation
|
you need to fix star imports and revert java back to 6 |
4 similar comments
|
you need to fix star imports and revert java back to 6 |
|
you need to fix star imports and revert java back to 6 |
|
you need to fix star imports and revert java back to 6 |
|
you need to fix star imports and revert java back to 6 |
|
hmm, apparently fasthub client is seriously bugged. |
|
@liach I'll Fix Star Imports in a little while, but unfortunately I will not be reverting Java. The reason of which is that Java 6 isn't even supported under 1.12.X. It was changed to prevent anyone who happened to use Java 6 with 1.12.2 (May make this same change to 1.12.0 and .1) |
|
actually you should bump not because of minecraft but because of gradle (requires j7) |
|
Please fix the following issues:
|
|
Alright. I'll do so in a little while (Not near a PC ATM to do this until a few hours from now) |
This Commit Upgrades Dependencies to be more compatible with 1.12.2 as well as replaces any deprecation issues.
|
Feel Free to Check this again now, as all of @Mumfrey s Points plus Starred Imports are now fixed. |
|
Are there still issues with this pull? If not, seems like things have been fixed. Also, I'm creating a new issue regarding Pam's Harvestcraft and this, as it seems that liteloader has broken the HC right-click to harvest crops functionality. This is not favorable, as I prefer not to break my crops when harvesting. |
|
I need to have a look into it. I'm really not sure how anything in the installer has anything to do with "compatibility with 1.12.2" because I see no changes here that have anything to do with compatibility. It just seems like some dependencies were changed for no particular reason. |
CDAGaming
changed the title
[Fix] Revert to Java v1.6 for Installer [Fix] Add dependsOn to createExe (It does work) [Fix] Fixed a GString Reference in Installer FileDescription [Change] createExe#jar now is a GString [Change] project.verRelease is now 00, not -00 (Fixed Format in version to have the dash)
(Installer EXE is still outputted at build/launch4j now launch/createExe)
|
All Requested Changes are now Done! Sorry it has taken so long, but this PR should now be good to go. |
5 participants
This PR Upgrades Dependencies to be more compatible with 1.12.2 as well as replaces most deprecation issues.
Edit: Renamed PR to Improved, as this PR isn't a requisite for 1.12.2 compatibility and merely improves upon it.