Feat/auth tests and pagination#1322
Merged
Merged
Conversation
Cover validateUser (found, not-found, re-throw), findById, and register stub in AuthService with proper mock isolation.
Validate LoginDto (email, username, password) and RegisterDto (email, password minLength, firstName, lastName, role enum) with class-validator, covering missing fields, wrong types, and combined errors.
Integration tests for GET /v1/auth/profile and GET /v1/auth/users endpoints using supertest with JWT auth, covering 401 for missing/invalid tokens and 200 for valid authenticated requests.
Add GET /v1/auth/users with cursor/page/limit query params using the existing PaginationDto and PaginatedResponseDto. Wire findAll in UsersService with findAndCount, expose via AuthService.findAllUsers, and add GET /v1/auth/profile endpoint. Update controller spec.
|
@sundayjob996 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1047
closes #1048
closes #1049
closes #1050
backend module Auth (auth). Add service unit tests for happy path.
Backend module Auth (auth). Add DTO validation tests for invalid input.
Backend module Auth (auth). Add e2e test for primary endpoint.