feat(social-links): document endpoints in Swagger/OpenAPI#1337
Merged
Conversation
- Add SocialLinksListItemDto (concrete class with id) so Swagger can resolve the paginated list schema instead of an un-resolvable generic - Register PaginatedResponseDto and SocialLinksListItemDto via @ApiExtraModels; use allOf + getSchemaPath for the GET 200 schema - Add type annotations to POST 201 and PATCH 200 responses - Add 400 (validation) and 429 (rate-limit) @apiresponse decorators on mutating endpoints; add @ApiBody and example values on query params - Add 14 Swagger metadata unit tests covering tags, extra-models registration, operation summaries, response types, and status codes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Damidesign Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #1059
this pr closes #1060
Summary
Changes
Test Plan
Automated tests added or updated
backend/src/**/*.spec.ts) — service/guard/decorator logic in isolationbackend/test/**/*.e2e-spec.ts) — HTTP round-trips with mocked infrastructurefrontend/src/**/*.test.{ts,tsx}) — React component behaviourfrontend/e2e/**/*.spec.ts) — Playwright browser flowscontract/) — Soroban/Rust unit tests viacargo testHow to run the tests locally
Manual verification checklist
cd backend && npm run lint/cd frontend && npm run lintRelated issues
Notes for reviewers