Skip to content

Fix benefit-card timeouts: scalar subquery instead of CROSS JOIN totals (MFB-867) #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catonph merged 1 commit into from
Jun 2, 2026
Merged

Fix benefit-card timeouts: scalar subquery instead of CROSS JOIN totals (MFB-867) #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions dashboards/sql/current_benefits.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
WITH totals AS (
SELECT count(*) AS total_count FROM analytics.mart_screener_data
WHERE 1 = 1 [[AND {{submission_date}}]] [[AND {{partner}}]] [[AND {{county}}]] [[AND {{utm_campaign}}]] [[AND {{utm_medium}}]] [[AND {{utm_source}}]]
),

filtered_screens AS (
WITH filtered_screens AS (
SELECT id
FROM analytics.mart_screener_data
WHERE 1 = 1 [[AND {{submission_date}}]] [[AND {{partner}}]] [[AND {{county}}]] [[AND {{utm_campaign}}]] [[AND {{utm_medium}}]] [[AND {{utm_source}}]]
Expand All @@ -12,10 +7,13 @@ filtered_screens AS (
SELECT
max(cb.benefit_display_name) AS "Benefit Name",
count(DISTINCT cb.screen_id) AS "# of Screeners",
count(DISTINCT cb.screen_id)::FLOAT / nullif(max(t.total_count), 0) AS "% of Screeners"
count(DISTINCT cb.screen_id)::FLOAT / nullif((
SELECT count(*)
FROM analytics.mart_screener_data
WHERE 1 = 1 [[AND {{submission_date}}]] [[AND {{partner}}]] [[AND {{county}}]] [[AND {{utm_campaign}}]] [[AND {{utm_medium}}]] [[AND {{utm_source}}]]
), 0) AS "% of Screeners"
FROM analytics.mart_current_benefits cb
INNER JOIN filtered_screens fs ON cb.screen_id = fs.id
CROSS JOIN totals t
GROUP BY cb.benefit_name
HAVING count(DISTINCT cb.screen_id) > 0
ORDER BY count(DISTINCT cb.screen_id) DESC, max(cb.benefit_display_name) ASC
14 changes: 6 additions & 8 deletions dashboards/sql/immediate_needs.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
WITH totals AS (
SELECT count(*) AS total_count FROM analytics.mart_screener_data
WHERE 1 = 1 [[AND {{submission_date}}]] [[AND {{partner}}]] [[AND {{county}}]] [[AND {{utm_campaign}}]] [[AND {{utm_medium}}]] [[AND {{utm_source}}]]
),

filter_keys AS (
WITH filter_keys AS (
SELECT DISTINCT
coalesce(partner, '__NULL__') AS partner,
coalesce(county, '__NULL__') AS county,
Expand All @@ -17,7 +12,11 @@ filter_keys AS (
SELECT
n.benefit AS "Need Category",
sum(n.count) AS "# of Screeners",
sum(n.count)::FLOAT / nullif(max(t.total_count), 0) AS "% of Screeners"
sum(n.count)::FLOAT / nullif((
SELECT count(*)
FROM analytics.mart_screener_data
WHERE 1 = 1 [[AND {{submission_date}}]] [[AND {{partner}}]] [[AND {{county}}]] [[AND {{utm_campaign}}]] [[AND {{utm_medium}}]] [[AND {{utm_source}}]]
), 0) AS "% of Screeners"
FROM analytics.mart_immediate_needs n
INNER JOIN filter_keys fk
ON
Expand All @@ -26,6 +25,5 @@ INNER JOIN filter_keys fk
AND coalesce(n.utm_campaign, '__NULL__') = fk.utm_campaign
AND coalesce(n.utm_medium, '__NULL__') = fk.utm_medium
AND coalesce(n.utm_source, '__NULL__') = fk.utm_source
CROSS JOIN totals t
GROUP BY n.benefit
ORDER BY sum(n.count) DESC, n.benefit ASC
15 changes: 6 additions & 9 deletions dashboards/sql/qualified_benefits.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
WITH totals AS (
SELECT count(*) AS total_count
FROM analytics.mart_screener_data
WHERE 1 = 1 [[AND {{submission_date}}]] [[AND {{partner}}]] [[AND {{county}}]] [[AND {{utm_campaign}}]] [[AND {{utm_medium}}]] [[AND {{utm_source}}]]
),

filter_keys AS (
WITH filter_keys AS (
SELECT DISTINCT
coalesce(partner, '__NULL__') AS partner,
coalesce(county, '__NULL__') AS county,
Expand All @@ -18,7 +12,11 @@ filter_keys AS (
SELECT
qb.benefit AS "Benefit Name",
sum(qb.count) AS "# of Screeners",
sum(qb.count)::FLOAT / nullif(max(t.total_count), 0) AS "% of Screeners"
sum(qb.count)::FLOAT / nullif((
SELECT count(*)
FROM analytics.mart_screener_data
WHERE 1 = 1 [[AND {{submission_date}}]] [[AND {{partner}}]] [[AND {{county}}]] [[AND {{utm_campaign}}]] [[AND {{utm_medium}}]] [[AND {{utm_source}}]]
), 0) AS "% of Screeners"
FROM analytics.mart_qualified_benefits qb
INNER JOIN filter_keys fk
ON
Expand All @@ -27,6 +25,5 @@ INNER JOIN filter_keys fk
AND coalesce(qb.utm_campaign, '__NULL__') = fk.utm_campaign
AND coalesce(qb.utm_medium, '__NULL__') = fk.utm_medium
AND coalesce(qb.utm_source, '__NULL__') = fk.utm_source
CROSS JOIN totals t
GROUP BY qb.benefit
ORDER BY sum(qb.count) DESC, qb.benefit ASC
Loading