Player results - implement separate page for better UX+UI - #92
Open
JanMikes wants to merge 2 commits into
Open
Conversation
JanMikes
force-pushed
the
player-results-page
branch
from
February 22, 2026 17:05
d5dbe14 to
0429ac8
Compare
Two defects in the player-results commit, both pre-existing rather than rebase fallout, found while verifying the rebase against current main. PuzzleTimes: duo/team rows are PuzzleSolversGroup, which has no playerId, so building the link threw a Twig RuntimeError (500 on puzzle detail whenever a team solved the same puzzle more than once). Fall back to the first registered team member, and omit the link when none is registered. _player_solvings: for duo/team rows puzzle.playerId is the solving time's owner, not necessarily the profile owner, so the link could point at a different player's results. Use the component's playerId. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NFMh9JCxZZVmwcLV6tq34z
JanMikes
force-pushed
the
player-results-page
branch
from
July 27, 2026 13:57
0429ac8 to
f1a0d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.