add walrus-deploy binary#203
Merged
Merged
Conversation
Adds binaries/walrus-deploy.toml so `suiup install walrus-deploy` works. The walrus-deploy binary lives inside the existing per-platform tarballs that MystenLabs/walrus publishes, alongside walrus / walrus-node / walrus-upload-relay (added upstream in MystenLabs/walrus#3349). shared_repo_binary=true mirrors sui-node.toml's pattern: the binary's name doesn't match the archive identifier (archive is `walrus-*.tgz`, binary is `walrus-deploy`), so suiup must look up by repo and extract by filename rather than by archive name. Earliest walrus release this works against is v1.49 (the first release whose tarballs include walrus-deploy after MystenLabs/walrus#3349 landed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `binaries/walrus-deploy.toml` so `suiup install walrus-deploy` works on every supported platform.
The walrus-deploy binary lives inside the existing per-platform release tarballs that MystenLabs/walrus publishes — it was added to the `release_binaries` set upstream in MystenLabs/walrus#3349 (landed). suiup just needs the registry entry to know about it; `build.rs` auto-discovers everything in `binaries/`.
Why `shared_repo_binary = true`
Mirrors the `sui-node.toml` / `move-analyzer.toml` pattern: the binary name doesn't match the archive identifier (archive is `walrus--v<X.Y.Z>--.tgz`, binary inside is `walrus-deploy`), so suiup needs to look up the archive by repository and then extract by filename rather than by archive name.
Local verification
```
$ cargo run --quiet -- list
Binary Description
══════════════════════════════════════
...
walrus Walrus CLI
walrus-deploy Walrus deployment CLI
...
```
Backwards compatibility
Net new file. No changes to any other binary's config or to suiup core. `build.rs` already auto-discovers `binaries/*.toml` at build time and embeds them, so no source code edits are required.
Test plan
Sequencing
This PR can land any time, but `suiup install walrus-deploy` only succeeds against walrus releases v1.49.0+. Any earlier tag's tarballs don't contain walrus-deploy.
Reported by
Michael Hayes (Slack thread) — building a local-dev-stack tool, currently stuck rebuilding walrus from source for ~15-20 min on every cold start because walrus-deploy isn't a release artifact.
🤖 Generated with Claude Code