Switch framework from Sinatra to Roda#38
Open
jeremyevans wants to merge 2 commits into
Open
Conversation
There is a lot of duplication in the Sinatra routes, and using a routing tree DRYs things up. Remove sinatra/partials.rb, replace with simpler partial method. This currently comments out the Sinatra::Reloader use. It's fairly simple to switch to different reloading library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering Ginatra's name, I don't think acceptance of this
pull request is very likely, but I think using a routing tree will
DRY up pretty much all the routes (e.g.
@repo = RepoList.find(...)in only one place).All specs pass with this, and it seems to work in some basic
testing. If switching the framework from Sinatra to Roda is
something you'll consider, but you have issues with this
implementation, I'll be happy to address any issues.
The diff is probably best viewed with
-bdue to indentationchanges related to the switch to a routing tree.