Activity Search Phase 1 by joswig · Pull Request #1875 · NASA-AMMOS/plandev-ui

joswig · 2026-02-16T04:41:12Z

Summary

New /search page for finding activity directives across all plans, plus shared-component improvements that came out of building it.

Search page

Filters (all bookmarkable via URL query params):

Mission Model
Activity Type (multi-select; narrowed by selected model)
Activity Name
Argument Name (typeahead from the selected model's parameter schemas; narrows further with a selected Type)
Argument Value (tooltip notes mission-model defaults are not applied. Also – typing 5 matches XYZ: 5 and XYZ: [1, 2, 5]; arrays/structs accepted as JSON)
Tag
Preset (model-filtered)
Created By
Last Modified By
Created After / Created Before
Last Modified Before / After
Start Offset min/max
Plan Name
Plan Owner
Plan Tag
Scheduling Goal
Scheduler-created only

Results:

Server-side pagination, 50/page, with aggregate count
Server-side sort translated from AG Grid column state
Sticky-footer Search/Clear
500ms-delayed spinner overlay during search
Inline banner for subscription errors
Per-dropdown loading state

Columns (default-visible unless noted):

Open in plan (pinned-left icon, full-cell click)
Activity Name, Activity Type, Activity ID (hidden)
Plan Name, Plan Owner, Plan ID (hidden), Model, Model ID
Tags, Applied Preset
Start Offset, Absolute Start Time, Arguments (hidden)
Created By, Created At (hidden), Modified By, Last Modified
Scheduling Goal, Sched. Goal ID (hidden)
Column picker with show/hide all + reset (action column is structural, exempt)
Visibility, order, width, sort, pinning persisted to localStorage

Selection & cross-plan copy:

Click / cmd-click / shift-click selects rows
Right-click menu: "Copy N Activities" puts the selection on the clipboard
"Open in plan" — per-row icon button (always visible, pinned left) and a right-click menu item when exactly one row is selected
Paste in the target plan via the existing in-plan paste context menu. Cross-plan timing re-grounds correctly (see fixes below but needs review/discussion)

Shared changes

DataGrid:

New persistColumnStateKey + transformColumnState props centralize column-state localStorage save/clear
Forwarded through BulkActionDataGrid and SingleActionDataGrid
WSP and SearchResults consume it
WSP keeps its name-column processing via transformColumnState

SearchableDropdown:

Menu width uses canvas measureText with font read off a hidden DOM ref (replaces the maxOptionChars * 8 heuristic that overshot for proportional fonts)
Items flow through RowVirtualizerFixed as a slot prop so menus refresh while open
New loading prop
Internal toggle button got type="button" so Enter inside a sibling input no longer toggles the menu

RowVirtualizerFixed:

items prop replaces count; slot exposes item
TimelineItemList + mock updated

Bug fixes & polish

Cross-plan paste now respects the user's right-click paste-at-time even when source activities' absolute times fall outside the target plan window (previously snapped to plan start). Needs review/discussion. Additionally, copy/paste was modified to keep track of directive origin plan in order to avoid clobbering directives from different plans with the same IDs.
DataGrid: switched the selected-row class toggle to querySelectorAll so pinned-left and center containers stay in sync (fixes two-tone selected row with pinned columns — affects every table with pinned columns, not just search)

Test plan

Filter combinations produce expected results
Pagination traverses all pages
Each sortable column sorts via server
URL state round-trips across refresh
Column-picker state persists across reload
Error banner appears on subscription failure

TODO

e2e tests
Tooltip for argument name width bugfix
Multi-select activity type filter
Multi-select + cross-plan copy flow
Model / Model ID / Absolute Start Time / Scheduling Goal columns
Activity ID sort bug fix
Cross-plan paste-at-time bug fix
New filters: Last Modified By, Created date range, Plan Tag, Scheduling Goal

Future Work

Future directions for this work could involve:

Search on activity instances (spans), requires sorting out which simulation dataset to query for each plan.
Making use of the activity filter builder paradigm to enable more complex search expressions
Searching for plans that contain various activities
Searching for activities similar to the one currently selected in a plan
Command palette menu integration (once WIP Command Palette 🎨 #1824 is completed) for cross-app activity search without needing to start on /search page
Potentially adding a db table/view that would actually give us queryable directive arguments. This has likely been considered in the past but not sure what technical barriers exist.
Instantiate cross-plan activity search within a plan panel
Constraint violation search - find activities involved in constraint violations
Temporal search with absolute times via new computed Hasura field (or two phase query) to resolve absolute times
Aggregate views to offer summaries of activity type distribution across plans, parameter value distribution for a selected type/argument, etc

AaronPlave · 2026-02-18T16:08:48Z

This feels very useful, so much potential here

dandelany · 2026-06-01T21:56:05Z

@AaronPlave is working on testing this at larger scale (~100k-1M directives), will hold off on final approval until done

AaronPlave · 2026-06-02T00:01:21Z

@AaronPlave is working on testing this at larger scale (~100k-1M directives), will hold off on final approval until done

@dandelany did some performance testing and found that with 500k activities search performance was usually under a few seconds with the exception of search with a sort on directives by plan name (requiring a join) with no other significant filters to reduce result set - in that case search was slower but maybe 5-10 seconds on my machine, which feels like acceptable performance.

- Server-side pagination (offset + aggregate count) with first/prev/next/last controls - Expanded filters: plan name/owner, created_by, last-modified date range, scheduling-goal origin - Argument name dropdown driven by the selected model's activity type parameter schemas; narrows further when an activity type is selected - Server-side sort: AG Grid column state translated to nested Hasura order_by - All filter state encoded in URL query params (bookmarkable / shareable searches), initialized on load with deferred model-id resolution while subscription primes - Result table: tag chips, JSON arguments column, formatted timestamps via getShortISOForDate, plus toggleable Created At / Plan ID / Activity ID columns - Column picker (ActivityTableMenu) with show/hide all + reset; column state persisted via localStorage. Forward columnVisible / columnsReset events through SingleActionDataGrid so the picker can react - Search button always enabled; auto-search-on-load still gated on a non-empty filter

Adds persistColumnStateKey + transformColumnState props on DataGrid (forwarded through BulkAction/SingleActionDataGrid). WorkspaceFileBrowser drops its duplicated save/clear logic and rides its name-column processing through transformColumnState.

Replace maxOptionChars*8 width estimate with canvas measureText, reading the font off a hidden DOM ref so it tracks CSS. Pass items through RowVirtualizerFixed as a slot prop (fixes stale content when array changes in place). Add loading prop. TimelineItemList + mock updated for new virtualizer API.

Mission Model uses SearchableDropdown. Collapse pending-model state into a single selectedModelId (selectedModel derived). Inline subscription-error banner. Per-dropdown loading. Start Offset min/max filters. Argument Value defaults tooltip. Search always enabled, above Clear, sticky footer. 500ms-delayed spinner overlay over results; no-op local sort comparators avoid the flash before server-sorted data lands. SearchResults adopts the new persistColumnStateKey for column-state persistence.

UI / UX - Multi-select Activity Type filter (`_in` clause); arg-name dropdown handles multi - New filters: Last Modified By, Created After/Before, Plan Tag, Scheduling Goal - New columns: Model, Model ID, Absolute Start Time, Scheduling Goal - Column order regrouped: action → identity → plan/model → tagging → timing → audit → provenance - Open-in-plan: Svelte component cell, full-cell click, pinned-left icon column - Right-click context menu: "Copy N Activit(ies)" and "Open in plan" (single-select) - Click-drag column resize (no shift-key required) - Open-in-plan exempt from column picker and the "hide all" sweep Behavior fixes - Cross-plan paste respects the right-click paste-at-time even when the source activities' absolute times fall outside the target plan window - Arg value matching: JSON.parse + singleton-array sugar so typing `5` finds `XYZ: 5` and `XYZ: [1, 2, 5]`; numeric/bool branch covers all four shapes - Drop the `directive_id: id` gql alias — fixes Hasura sort error on Activity ID - DataGrid: querySelectorAll so the selected-row class stays in sync between center and pinned-left containers (fixes the two-tone selected row bug) Types / internals - ActivityDirectiveSearchResult now extends ActivityDirectiveDB instead of redefining shared fields; corrects applied_preset shape along the way - SEARCH_ACTIVITIES extends plan with mission_model, adds source_scheduling_goal, anchor_id, anchored_to_start, metadata for the clipboard mapping - Use ColumnPinnedType / SortDirection imports for the two literal ColDef fields

Activity directive ids are unique per-plan but not globally; cross-plan search results can collide on the bare id. Key the search results grid and the clipboard/paste anchor remap by (plan_id, id) so row identity, selection, and anchor preservation stay scoped to the source plan.

sonarqubecloud · 2026-06-04T17:55:07Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

dandelany

This is looking good, and we've done plenty of testing on it! The performance and UX on my local machine are great. I think it's ready to merge.

Added a few nonblocking comments below - one's easy, but for the others, the effort probably isn't worth the impact for V1.

dandelany · 2026-06-06T02:49:06Z

+        user,
+      );
+
+      if (result) {


I think this can occasionally show incorrect results if you quickly change from a slow search to a fast search, the earlier slow results can come in after the fast ones and replace them as the "most recent" when they're not.

I consider this a nonblocker for this PR because you have to be trying pretty hard to make this happen, and this is an MVP feature, and the fix is nontrivial

dandelany · 2026-06-06T02:52:00Z

+          bind:dataGrid
+          bind:selectedItemIds
+          getRowId={getRowKey}
+          idKey="id"


confirmed the original bug was resolved - idKey should probably just be removed here in favor of getRowId for clarity, since it gets overridden when getRowId is provided

dandelany · 2026-06-06T02:58:45Z

+    return measureCanvasContext;
+  }
+
+  function measureMaxOptionWidth(opts: DropdownOptions): number {


It's annoying that we have to do this whole layout measuring dance... I think I understand why, due to the RowVirtualizer needing real static sizes? Let's ship it if there's not an easy alternative, and I'm guessing there's not. But worth thinking about the best pattern in future

joswig temporarily deployed to test-workflow February 16, 2026 04:41 — with GitHub Actions Inactive

joswig force-pushed the dev/activity_search branch from 237d865 to 2a5f418 Compare February 16, 2026 20:19

joswig temporarily deployed to test-workflow February 16, 2026 20:19 — with GitHub Actions Inactive

joswig temporarily deployed to test-workflow February 16, 2026 20:50 — with GitHub Actions Inactive

joswig temporarily deployed to test-workflow February 24, 2026 23:10 — with GitHub Actions Inactive

joswig temporarily deployed to test-workflow February 24, 2026 23:23 — with GitHub Actions Inactive

AaronPlave force-pushed the dev/activity_search branch from 9e5e9c4 to 1849440 Compare April 21, 2026 15:52

AaronPlave temporarily deployed to test-workflow April 21, 2026 15:52 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow April 27, 2026 16:25 — with GitHub Actions Inactive

AaronPlave force-pushed the dev/activity_search branch from b91a810 to 34a44a1 Compare April 27, 2026 17:38

AaronPlave temporarily deployed to test-workflow April 27, 2026 17:38 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow April 27, 2026 19:41 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow April 28, 2026 00:47 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow April 28, 2026 14:27 — with GitHub Actions Inactive

AaronPlave had a problem deploying to test-workflow April 28, 2026 14:31 — with GitHub Actions Failure

AaronPlave temporarily deployed to test-workflow April 28, 2026 15:25 — with GitHub Actions Inactive

AaronPlave self-assigned this Apr 28, 2026

AaronPlave changed the title ~~activity search form~~ Activity Search Phase 1 Apr 28, 2026

AaronPlave temporarily deployed to test-workflow April 28, 2026 15:52 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow April 28, 2026 15:59 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow April 28, 2026 16:04 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow April 28, 2026 16:08 — with GitHub Actions Inactive

AaronPlave marked this pull request as ready for review April 28, 2026 16:20

AaronPlave requested a review from a team as a code owner April 28, 2026 16:20

AaronPlave had a problem deploying to test-workflow April 28, 2026 16:20 — with GitHub Actions Failure

AaronPlave requested review from AaronPlave, dandelany and duranb April 28, 2026 16:20

AaronPlave temporarily deployed to test-workflow May 27, 2026 22:21 — with GitHub Actions Inactive

AaronPlave force-pushed the dev/activity_search branch from 8265694 to c4a558e Compare May 27, 2026 22:21

AaronPlave temporarily deployed to test-workflow May 27, 2026 22:21 — with GitHub Actions Inactive

AaronPlave temporarily deployed to test-workflow May 27, 2026 22:27 — with GitHub Actions Inactive

joswig and others added 20 commits June 4, 2026 10:52

activity search form

5175f0b

limit search results, define permissions, display preset

9cd3452

search presets

3328d9d

updated test models

9592a09

Add pagination, filters, sorting, and deep linking

ab8e358

Improve activity argument UX

c887af0

Style fix

0d8c0af

e2e and unit tests for activity search

37d8e5d

Fix tooltip sizing

83895ef

Lint

9f8401e

Type fix

67ede03

Fix

6c9c85b

Lint

173a54d

Format

012256d

AaronPlave force-pushed the dev/activity_search branch from d5e1f32 to 012256d Compare June 4, 2026 17:52

AaronPlave temporarily deployed to test-workflow June 4, 2026 17:52 — with GitHub Actions Inactive

dandelany approved these changes Jun 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activity Search Phase 1#1875

Activity Search Phase 1#1875
joswig wants to merge 20 commits into
developfrom
dev/activity_search

joswig commented Feb 16, 2026 •

edited by AaronPlave

Loading

Uh oh!

AaronPlave commented Feb 18, 2026 •

edited

Loading

Uh oh!

dandelany commented Jun 1, 2026

Uh oh!

AaronPlave commented Jun 2, 2026

Uh oh!

sonarqubecloud Bot commented Jun 4, 2026

Uh oh!

dandelany left a comment

Uh oh!

dandelany Jun 6, 2026

Uh oh!

dandelany Jun 6, 2026

Uh oh!

dandelany Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joswig commented Feb 16, 2026 • edited by AaronPlave Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Search page

Shared changes

Bug fixes & polish

Test plan

TODO

Future Work

Uh oh!

AaronPlave commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dandelany commented Jun 1, 2026

Uh oh!

AaronPlave commented Jun 2, 2026

Uh oh!

sonarqubecloud Bot commented Jun 4, 2026

Quality Gate failed

Uh oh!

dandelany left a comment

Choose a reason for hiding this comment

Uh oh!

dandelany Jun 6, 2026

Choose a reason for hiding this comment

Uh oh!

dandelany Jun 6, 2026

Choose a reason for hiding this comment

Uh oh!

dandelany Jun 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joswig commented Feb 16, 2026 •

edited by AaronPlave

Loading

AaronPlave commented Feb 18, 2026 •

edited

Loading