Support SWOT-DA for HYMAP3

[yyoon4]

Description

SWOT-based data-assimilation (DA) support for the HYMAP3 routing module (#1749, #1750)

Testcase

/discover/nobackup/yyoon4/lis7/Testcase/swot_da_hymap3

[emkemp]

Hi @yyoon4

I reproduced the results from your test case. Hooray!

Question: Is this PR intended for the LISF 7.8 557WW release, or is this for another project?

[yyoon4]

No,

Hi @yyoon4

I reproduced the results from your test case. Hooray!

Question: Is this PR intended for the LISF 7.8 557WW release, or is this for another project?

No, it is not intended for the LISF 7.8 557WW release. It is just for the master branch and for use in the SWOT project.

[emkemp]

Hi @yyoon4

At this point, we have two remaining issues with this pull request.

(1) The lis.config entries for da_SWOT in HYMAP3 are identical to the entries for da_ML. Does this need to change, i.e., should the config options mention "SWOT" or "ML" as well as "HYMAP3" for clarity?

(2) Can you review the existing LIS user guide and update as necessary for this PR?

Thanks.

[yyoon4]

@emkemp

Thanks for checking and cleaning code.

da_WL is intended for synthetic water level DA. I believe this code was copied from HyMAP2, but it has not been tested, so I am not sure whether it works correctly. The da_WL code is generally similar to da_SWOT; however, da_SWOT has since been updated to support SWOT observations and the new localization approach. For now, I believe it would be better to remove the directory from HyMAP3.

For lis.config, the basic concept is the same as for SWOT, so the configuration entries are similar.

However, da_SWOT uses:
Data assimilation set: "SWOT water level"

I revised the lis.config file as follows:

Observation perturbation algorithm: "GMAO scheme"
Observation perturbation frequency: "1hr"
Observation attributes file: ./input/da/swotobs_attribs.txt
Observation perturbation attributes file: ./input/da/swotobs_pertattribs.txt

I also updated 'lis.config.adoc' file

[emkemp]

Thanks @yyoon4.

@jvgeiger: Any objections to me removing lis/routing/HYMAP3_router/da_WL?