Skip to content

Update Cost_survey.md#22

Open
SWerner2 wants to merge 7 commits intomasterfrom
SWerner2-patch-1
Open

Update Cost_survey.md#22
SWerner2 wants to merge 7 commits intomasterfrom
SWerner2-patch-1

Conversation

@SWerner2
Copy link
Collaborator

Updates cost survey data info for Oracle

SWerner2 and others added 3 commits July 21, 2023 09:40
Updates cost survey data info for Oracle
typo fix again.
@mle2718 mle2718 self-requested a review July 21, 2023 14:08
@mle2718
Copy link
Member

mle2718 commented Jul 21, 2023

@SWerner2 : Thanks for putting this out there.

  1. When I do:
select * from SSB_COST_SURVEY.VCS_COST20211;

I get a message that "the table or view does not exist". I also don't see anything when I look at the SSB_COST_SURVEY user in sqldeveloper. I am pretty sure this means that I don't have viewing rights. The owner (probably you) will need to grant access.

Screenshot (94)

  1. The excel data on the network had predicted trip costs. Is the data in oracle the same, or is it something different? I think it's something different. If so, i think we should change the layout a bit -- the info on predicted trip costs is not really "cost survey" and deserves it's own file/entry.

Copy link
Member

@mle2718 mle2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SWerner2 --
this looks good. Can you make sure to grant permissions? I can't actually see those tables.

@mle2718
Copy link
Member

mle2718 commented Sep 26, 2023

The sql query still doesn't work for me. I'm pretty sure it's a permissions issue.

@mle2718
Copy link
Member

mle2718 commented Oct 25, 2023

@SWerner2 : Thanks for putting this out there.

1. When I do:
select * from SSB_COST_SURVEY.VCS_COST20211;

I get a message that "the table or view does not exist". I also don't see anything when I look at the SSB_COST_SURVEY user in sqldeveloper. I am pretty sure this means that I don't have viewing rights. The owner (probably you) will need to grant access.

Screenshot (94)

2. The excel data on the network had predicted trip costs.  Is the data in oracle the same, or is it something different?  I think it's something different. If so, i think we should change the layout a bit -- the info on predicted trip costs is not really "cost survey" and deserves it's own file/entry.

@SWerner2 : just following up on this. I can't access that particular table.

@SWerner2
Copy link
Collaborator Author

@mle2718 Thanks for raising this Min-Yang.

  1. These are the commercial fishing cost survey data. Tanya, myself, Greg and Elizabeth are working hard to compile comprehensive metadata bookdown site for the tables / views prior to the official Oracle "roll out". All the data is still available on the network drive in the meantime (socialsci\Cost_survey_data_all_years)

  2. This is not the trip cost data. Databasing the trip cost estimates on Oracle will most likely occur in a few years given that we are prioritizing databasing the 2022 cost survey data and potentially the 2006-2008 data. I can make a new file entry for trip costs if one hasn't yet been created.

@mle2718
Copy link
Member

mle2718 commented Oct 25, 2023

@SWerner2 : thanks
The previousy "Cost Survey" markdown file is this:

The cost survey data can be found on the socialscience drive at \net\work5\socialsci\Cost_survey_data_all_years

Here is a bit of R code that you can use to read in that data:

net<-full.path.to.net
cost_directory<-file.path(net,"work5","socialsci","Trip_Costs","2007-2020")
X2007_2012 <- read_excel(file.path(cost_directory,"2007_2012.xlsx"))
X2013_2020 <- read_excel(file.path(cost_directory,"2013_2020.xlsx"))

More to follow. It is not stored in oracle.

This is not quite correct because I had conflated trip costs and the cost survey.

It is probably a good idea to keep some sample R code around to read trip costs into R. I will make some suggestions and send them for your approval.

@mle2718
Copy link
Member

mle2718 commented Oct 25, 2023

@SWerner2 : how does #26 look to you?

@mle2718
Copy link
Member

mle2718 commented Oct 26, 2023

@SWerner2 : Okay, the only hurdle left before merging is that I can't select on any of those oracle tables.

@mle2718
Copy link
Member

mle2718 commented Jan 30, 2024

@SWerner2 -- hey, I just noticed this is still hanging out here. I tried to select on this table and I still can't do that. Any idea what's going on? Should I open a ticket with ITD to get access?

@SWerner2
Copy link
Collaborator Author

@SWerner2 -- hey, I just noticed this is still hanging out here. I tried to select on this table and I still can't do that. Any idea what's going on? Should I open a ticket with ITD to get access?

These are the commercial fishing cost survey data. Tanya, myself, Greg and Elizabeth are working hard to compile comprehensive metadata bookdown site for the tables / views prior to the official Oracle "roll out". All the data is still available on the network drive in the meantime (socialsci\Cost_survey_data_all_years)

This is not the trip cost data. Databasing the trip cost estimates on Oracle will most likely occur in a few years given that we are prioritizing databasing the 2022 cost survey data and potentially the 2006-2008 data. I can make a new file entry for trip costs if one hasn't yet been created.

@mle2718
Copy link
Member

mle2718 commented Jan 30, 2024

These are the commercial fishing cost survey data. Tanya, myself, Greg and Elizabeth are working hard to compile comprehensive metadata bookdown site for the tables / views prior to the official Oracle "roll out". All the data is still available on the network drive in the meantime (socialsci\Cost_survey_data_all_years)

I did not realize that the Oracle SSB_COST_SURVEY schema wasn't live. Based on the Cost_survey.md, it looked like it was up and running. What do you think we should do? I don't want to merge this PR, because then people will try to get cost data from oracle.

This is not the trip cost data. Databasing the trip cost estimates on Oracle will most likely occur in a few years given that we are prioritizing databasing the 2022 cost survey data and potentially the 2006-2008 data. I can make a new file entry for trip costs if one hasn't yet been created.

I understand that. We've already split the trip costs out of the Cost survey.md in PR #26.

@SWerner2
Copy link
Collaborator Author

These are the commercial fishing cost survey data. Tanya, myself, Greg and Elizabeth are working hard to compile comprehensive metadata bookdown site for the tables / views prior to the official Oracle "roll out". All the data is still available on the network drive in the meantime (socialsci\Cost_survey_data_all_years)

I did not realize that the Oracle SSB_COST_SURVEY schema wasn't live. Based on the Cost_survey.md, it looked like it was up and running. What do you think we should do? I don't want to merge this PR, because then people will try to get cost data from oracle.

-- We are hoping to go live in the next few months. Maybe putting a disclaimer for now that it isn't ready and they can get the data from network drive in the meantime (socialsci\Cost_survey_data_all_years).

@mle2718
Copy link
Member

mle2718 commented Jan 30, 2024

These are the commercial fishing cost survey data. Tanya, myself, Greg and Elizabeth are working hard to compile comprehensive metadata bookdown site for the tables / views prior to the official Oracle "roll out". All the data is still available on the network drive in the meantime (socialsci\Cost_survey_data_all_years)

I did not realize that the Oracle SSB_COST_SURVEY schema wasn't live. Based on the Cost_survey.md, it looked like it was up and running. What do you think we should do? I don't want to merge this PR, because then people will try to get cost data from oracle.

-- We are hoping to go live in the next few months. Maybe putting a disclaimer for now that it isn't ready and they can get the data from network drive in the meantime (socialsci\Cost_survey_data_all_years).

If you can make that change (and promise to remember to remove the disclaimer when you do go live), I'll merge the PR.

@SWerner2
Copy link
Collaborator Author

If you can make that change (and promise to remember to remove the disclaimer when you do go live), I'll merge the PR.

  • Can we just leave this as is until we go live?

@mle2718
Copy link
Member

mle2718 commented Jan 31, 2024

If you can make that change (and promise to remember to remove the disclaimer when you do go live), I'll merge the PR.

* Can we just leave this as is until we go live?

Sure, we can do that too.

@mle2718 mle2718 marked this pull request as draft January 31, 2024 13:28
@mle2718 mle2718 marked this pull request as ready for review January 14, 2025 15:42
@mle2718
Copy link
Member

mle2718 commented Jan 14, 2025

@SWerner2 and @Ardini-NOAA -- congrats Greg, Sam, and Elizabeth for getting this cost data into oracle.

I've marked this PR as "ready for review."

Could y'all give the changes a read to make sure it's still correct, it was written over a year ago?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants