use projected crs instead of silencing warning from geographic crs use#189
use projected crs instead of silencing warning from geographic crs use#189mdeshotel wants to merge 2 commits into
Conversation
| self.wrf_hydro_geo_meta = wrf_hydro_geo_meta | ||
| self.dest_crs = CRS(4326) | ||
| self.buffer = 0.02 # degree buffer around bounding box | ||
| self._temp_crs=CRS(5070) |
There was a problem hiding this comment.
Is this safe to use in Alaska and other oCONUS areas?
| self.dest_crs = CRS(4326) | ||
| self.buffer = 0.02 # degree buffer around bounding box | ||
| self._temp_crs=CRS(5070) | ||
| self.buffer = 3000 # m buffer around bounding box |
There was a problem hiding this comment.
Is 3km enough for all forcing sources including some of the lower-res ones? I am not sure what the rule of thumb should be, maybe something involving the diagonal of the largest anticipated pixel dimension that could be encountered in the wild? With some extra for safety and depending on how the regridding and sampling occurs.
There was a problem hiding this comment.
This should only effect historical forcing. Sources are only NWM retrospective (4km) and AORC (1km). I'll bump it up for the NWM retrospective.
| if self.mpi_config.rank == 0: | ||
| self.plot_precip(ds) |
There was a problem hiding this comment.
Is this intentional to create the plot file every time going forward?
There was a problem hiding this comment.
Not intentional; just forgot to comment it out again. Removed it now.
Use projected crs instead of geographic crs for buffering watershed. The new buffer seems reasonable and provides full coverage; see below.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support