Skip to content

use projected crs instead of silencing warning from geographic crs use#189

Open
mdeshotel wants to merge 2 commits into
developmentfrom
silence_crs_warning
Open

use projected crs instead of silencing warning from geographic crs use#189
mdeshotel wants to merge 2 commits into
developmentfrom
silence_crs_warning

Conversation

@mdeshotel

Copy link
Copy Markdown

Use projected crs instead of geographic crs for buffering watershed. The new buffer seems reasonable and provides full coverage; see below.

image

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@mdeshotel mdeshotel requested a review from mxkpp June 25, 2026 18:01

@mxkpp mxkpp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions:

  1. Is this safe to

self.wrf_hydro_geo_meta = wrf_hydro_geo_meta
self.dest_crs = CRS(4326)
self.buffer = 0.02 # degree buffer around bounding box
self._temp_crs=CRS(5070)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe to use in Alaska and other oCONUS areas?

self.dest_crs = CRS(4326)
self.buffer = 0.02 # degree buffer around bounding box
self._temp_crs=CRS(5070)
self.buffer = 3000 # m buffer around bounding box

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3km enough for all forcing sources including some of the lower-res ones? I am not sure what the rule of thumb should be, maybe something involving the diagonal of the largest anticipated pixel dimension that could be encountered in the wild? With some extra for safety and depending on how the regridding and sampling occurs.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only effect historical forcing. Sources are only NWM retrospective (4km) and AORC (1km). I'll bump it up for the NWM retrospective.

Comment on lines +238 to +239
if self.mpi_config.rank == 0:
self.plot_precip(ds)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional to create the plot file every time going forward?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentional; just forgot to comment it out again. Removed it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants