Skip to content

bandaid fix to deal with NWM rainrate being slightly negative in some…#190

Merged
mdeshotel merged 1 commit into
developmentfrom
negative_rainrate_nwm
Jun 26, 2026
Merged

bandaid fix to deal with NWM rainrate being slightly negative in some…#190
mdeshotel merged 1 commit into
developmentfrom
negative_rainrate_nwm

Conversation

@mdeshotel

Copy link
Copy Markdown

There appears to be an issue with the NWM Retrospective dataset where rain rate values fall very slightly negative. As a band aid fix I've replaced all slightly negative rain rate values with zero when reading the source dataset. 

https://jira.nextgenwaterprediction.com/browse/NGWPC-10972

Additions

Removals

Changes

Testing

  1. Testing performed in RTE. The issue was replicated then the remedy tested.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@mdeshotel mdeshotel merged commit ac54802 into development Jun 26, 2026
7 checks passed
@mdeshotel mdeshotel deleted the negative_rainrate_nwm branch June 26, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant