Skip to content

add retries for esmf mesh creation#192

Merged
mdeshotel merged 2 commits into
developmentfrom
esmf_creation_error
Jul 10, 2026
Merged

add retries for esmf mesh creation#192
mdeshotel merged 2 commits into
developmentfrom
esmf_creation_error

Conversation

@mdeshotel

@mdeshotel mdeshotel commented Jul 7, 2026

Copy link
Copy Markdown

Utilize the same retry function used in regrid.py for initial mesh creation in geomod.py.

https://jira.nextgenwaterprediction.com/browse/NGWPC-11202

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@mdeshotel mdeshotel requested a review from mxkpp July 7, 2026 18:52

@mxkpp mxkpp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good for intentionally retrying the ESMF.Grid and ESMF.Mesh calls, if they are intermittently failing in the environment they are running in due to temporary filesystem issues that can be overcome by simply retrying. The changes are using the appropriate dedicated retry functions for these ESMF methods that were added earlier.

I was not able to run the pytests since they are out of date relative to the recent hydrofabric and other expected test data / golden files. Soon we should update the test gpkg and golden files so that the pytests may run again.

@mdeshotel mdeshotel merged commit 6487222 into development Jul 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants