Skip to content

Fix MPI Type Error (NGWPC-11089)#193

Merged
idtodd merged 1 commit into
developmentfrom
idt-mpi-error-NGWPC-11089
Jul 13, 2026
Merged

Fix MPI Type Error (NGWPC-11089)#193
idtodd merged 1 commit into
developmentfrom
idt-mpi-error-NGWPC-11089

Conversation

@idtodd

@idtodd idtodd commented Jul 10, 2026

Copy link
Copy Markdown

Calibration runs were failing when there was only one catchment. The problem seems to be resolved by only broadcasting the AORC dataset slice when MPI has positively detected that there are other processes running. I'm unsure why this makes a difference based on documentation of how MPI should work, but testing shows it addresses the issue.

Additions

Removals

Changes

  • Check if there are multiple processes before broadcasting AORC data slice.

Testing

  1. Ian and Jeff both confirmed this addresses the issue using RTE calibration runs.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@idtodd idtodd changed the title Only broadcast the dataset if there are multiple MPI procs Fix MPI Type Error (NGWPC-11089) Jul 10, 2026
@idtodd
idtodd requested review from ar-siddiqui and mdeshotel and removed request for ar-siddiqui July 10, 2026 11:51
@idtodd
idtodd merged commit 97b0012 into development Jul 13, 2026
7 checks passed
@idtodd
idtodd deleted the idt-mpi-error-NGWPC-11089 branch July 13, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants