Open
Conversation
|
pata9
reviewed
Mar 13, 2026
Contributor
pata9
left a comment
There was a problem hiding this comment.
Guessing you can't dismiss/close the notification anymore? Have we ran that past the design guys?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Notification banner updated to use react components. The close action on the notification banner has been removed as it's not part of the design system and after speaking with Jon we decided we'd remove it. If it gets added back into the design system we will add that functionality back in but for now, the react components version of the notification banner doesn't know the concept of closing.
They banner itself is now scoped to a path so if a user navigates away from from the page the banner will disappear but if they navigate back within the default timeout it will reappear. The notification banner will still disappear after 15 seconds when performing an action as per original functionality.
Fixes # (issue)
Checklist: