Draft
Conversation
Incomplete because Cascade doesn't currently support serializing its Config or Spec types, only deserialization is supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this PR was to generate a modified Cascade config that the user could inspect and use, in the cases where changes to their config are required, e.g. to configure Cascade to publish signed zones on the same interfaces as the given OpenDNSSEC configuration uses.
However this PR is incomplete and on-hold because Cascade doesn't currently support serializing its
ConfigorSpectypes, only deserialization is supported.This is not a huge problem as
mainalready prints instructions to the user on how to modify their Cascade config, it would just be more user friendly and less error prone to generate proposed config changes for the user instead of them having to do it manually themselves.