Open
Conversation
ysims
reviewed
Jul 9, 2025
| // Use ground truth data from Webots | ||
| for (const auto& gt_robot : robots_ground_truth->robots) { | ||
| // Skip our own robot using GlobalConfig player_id and team colour | ||
| if (!(gt_robot.player_number == static_cast<int32_t>(PLAYER_ID) |
Member
There was a problem hiding this comment.
I wonder if its better to filter this in the webots module. Not a big deal though
module/localisation/RobotLocalisation/src/RobotLocalisation.cpp
Outdated
Show resolved
Hide resolved
module/localisation/RobotLocalisation/src/RobotLocalisation.hpp
Outdated
Show resolved
Hide resolved
A-Herfel
changed the title
A-Herfel
added
G-Localisation-Odometry
Co-authored-by: Ysobel Sims <35280100+ysims@users.noreply.github.com>
EthanBirdB
force-pushed
the
herfel/ground_truth_obstacles
branch
from
8e2a5ea to
d66ad07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds obstacle's ground truth data from Webots
Pre-PR Checklist:
Have you