Add more skip nvMolKit flags to benchmarks#189
Merged
Conversation
…ity) tfd_bench: `--skip-nvmolkit` to mirror the pre-existing `--skip-rdkit`, allowing RDKit-only runs (faster wall time on large sweeps). cross_similarity_bench: `--no-rdkit`/`--no-nvmolkit` plumbed via direct sys.argv inspection at import time, since pyperf's child worker processes re-import this module and re-parse argv (registered argparse flags do not propagate consistently to them).
evasnow1992
approved these changes
Jun 1, 2026
Collaborator
evasnow1992
left a comment
evasnow1992
left a comment
There was a problem hiding this comment.
Thank you for adding these flags. The changes look good to me.
We may consider consolidating similar flag names across the benchmark scripts for consistency as a future follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The similarity one is annoying because it uses pyperf, which actually subprocesses the entire file for multiple runs.