Use multiprocessing in ETKDG benchmark validation#190
Open
scal444 wants to merge 2 commits into
Open
Conversation
`_energy_diff_summary` gains a `num_threads` parameter; when > 1, MMFF energy evaluation runs in worker processes via `process_map`. Wired up from `main()` with `args.rdkit_threads`, so the same flag that controls the timed RDKit run also speeds up the (untimed) validation step.
evasnow1992
approved these changes
Jun 1, 2026
Collaborator
evasnow1992
left a comment
evasnow1992
left a comment
There was a problem hiding this comment.
Since --rdkit_threads is now overloaded, we may want to update its help text on line 274 to reflect the expanded behavior. Other changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was an unneeded bottleneck.