docs: close RC1 reference gaps for [targets] and switchyard-server options - #295
Open
eric-liu-nvidia wants to merge 2 commits into
Open
docs: close RC1 reference gaps for [targets] and switchyard-server options#295eric-liu-nvidia wants to merge 2 commits into
eric-liu-nvidia wants to merge 2 commits into
Conversation
Signed-off-by: Eric Liu <zengyuanl@nvidia.com>
Signed-off-by: Eric Liu <zengyuanl@nvidia.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThe documentation adds two server CLI options and clarifies TOML deployment requirements. It also adds a noop deployment example with an empty ChangesDocumentation references
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes two of the three RC1 public-docs gaps reported in SWITCH-1198 (NvBug SWYD-104). Both were found by a first-time-user pass over the
v0.2.0-rc.1docs.docs/reference/toml_schema.md— the page describednoopas a zero-upstream local smoke test, but a noop-only config is rejected withmissing field `targets`. The page now states thatschema_version,[targets], and[routes]must all be present even when a route reaches no upstream, that an empty[targets]table satisfies the requirement, and that[llm_clients]defaults to empty and may be omitted. A minimal noop-only example was added to thenoopsection.This matches
ServerConfig(crates/switchyard-server/src/config.rs), wherellm_clientscarries#[serde(default)]andtargetsdoes not.docs/cli_reference.md— theswitchyard-serveroptions table was missing two shipped options.--routing-log-file PATHis the one the report named;--shutdown-timeout(default30s) was also absent. Both are added in--helporder, since the reported expectation was that the table match--help.Verification
Against a fresh
cargo build --locked -p switchyard-serverat this branch:[targets]:invalid server config …: failed to parse TOML: … missing field targets[targets]and no[llm_clients]:server OK: noop-routeserver OK: noop-route--helpwere diffed in both directions — no option appears in one and not the other.mkdocs build --strictpasses.Deliberately not included: the
known_issues.md0.2.0 sectionThe third item in SWITCH-1198 asks for a 0.2.0 known-issues section covering #180, #200, #202, and #205. Those four are merged pull requests, not open issues — they are the fixes. Checked with
git merge-base --is-ancestor: none is an ancestor ofv0.2.0-rc.1, and all four are ancestors ofmain. They were real RC1 defects that landed after the RC was cut.Adding them to
known_issues.mdonmainwould ship 0.2.0 telling users that four already-fixed things are broken. The clearest case is the report's own evidence for #200:/v1/modelsreturning hardcodedcapabilities: {context_window: null, tool_calling: null}. Onmainthose fields are wired from route config inmodel_entry_json, and both are documented route keys in the schema page this PR edits.A real 0.2.0 known-issues list should be triaged from the currently-open bugs and is left to the docs owner, as the reporter offered in the ticket ("split into separate issues if preferred by the docs owner").
🤖 Generated with Claude Code
Summary by CodeRabbit
switchyard-serveroptions for configuring shutdown timeouts and routing log output.