Skip to content

docs(routing): the judge never sees client instructions - #311

Merged
ryan-lempka merged 1 commit into
mainfrom
rlempka/classifier-window-docs
Aug 5, 2026
Merged

docs(routing): the judge never sees client instructions#311
ryan-lempka merged 1 commit into
mainfrom
rlempka/classifier-window-docs

Conversation

@ryan-lempka

Copy link
Copy Markdown
Collaborator

The recent_turn_window docs claim the judge sees client system/developer instructions. It does not, and it never has — inbound decoders normalize that content into LlmRequest::instructions, which the judge request never reads.

The packaged classifier prompt agrees with the code, not the docs: it tells the judge it receives the task's opening instruction and latest user follow-up. Correcting the docs and the matching trim_messages comment.

Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
@ryan-lempka ryan-lempka changed the title docs(routing): the classifier judge is not shown client instructions docs(routing): the judge never sees client instructions Aug 5, 2026
@ryan-lempka
ryan-lempka marked this pull request as ready for review August 5, 2026 19:15
@ryan-lempka
ryan-lempka requested a review from a team as a code owner August 5, 2026 19:15
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.


Comment @coderabbitai help to get the list of available commands.

@ryan-lempka
ryan-lempka enabled auto-merge (squash) August 5, 2026 19:17
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

🚀 View preview at
https://NVIDIA-NeMo.github.io/Switchyard/pr-preview/pr-311/

Built to branch gh-pages at 2026-08-05 19:17 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ryan-lempka
ryan-lempka requested a review from ayushag-nv August 5, 2026 19:17
@ryan-lempka ryan-lempka self-assigned this Aug 5, 2026
@ryan-lempka
ryan-lempka merged commit 2a91472 into main Aug 5, 2026
18 checks passed
@ryan-lempka
ryan-lempka deleted the rlempka/classifier-window-docs branch August 5, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants