feat(studio): add CardSelect; update DataView toolbar and entityName tests - #1058
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesRadioCard indicator control
DataView toolbar visibility
Schema agreement tests
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/packages/common/src/components/DataView/StudioDataView.test.tsx (1)
83-85: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover selected-row toolbar behavior.
The context mock always returns
flatRows: [], whileBulkActionsindependently supplies all root rows. The current tests therefore bypass the production selection path. Mock one selected row throughgetSelectedRowModel()and assert thatrenderBulkActionsreceives it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/common/src/components/DataView/StudioDataView.test.tsx` around lines 83 - 85, Update the useInnerDataViewContext mock and related tests around renderBulkActions to return one selected row from getSelectedRowModel(). Add an assertion that renderBulkActions receives that selected row, ensuring the test exercises the production selected-row toolbar path instead of the fallback root-row behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@web/packages/common/src/components/DataView/StudioDataView.test.tsx`:
- Around line 83-85: Update the useInnerDataViewContext mock and related tests
around renderBulkActions to return one selected row from getSelectedRowModel().
Add an assertion that renderBulkActions receives that selected row, ensuring the
test exercises the production selected-row toolbar path instead of the fallback
root-row behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 10275622-0e29-4537-bc41-0173acf3120e
📒 Files selected for processing (4)
web/packages/common/src/components/CardSelect/index.tsxweb/packages/common/src/components/DataView/StudioDataView.test.tsxweb/packages/common/src/components/DataView/StudioDataViewToolbar.tsxweb/packages/common/src/utils/entityName.test.ts
Contributor
|
…ests - CardSelect: new common component for card-style option selection used by the eval config picker in SubmitEvaluationModal - StudioDataViewToolbar: adds support for row actions - entityName.test.ts: removes stale secrets SDK assertions after the secrets schema dropped named regex/max exports Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Octavian Drulea <odrulea@nvidia.com>
Signed-off-by: Octavian Drulea <odrulea@nvidia.com>
nv-odrulea
force-pushed
the
od/studio-common-updates
branch
from
August 4, 2026 18:06
10e25f5 to
0aa0870
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/common/src/components/RadioCard/index.test.tsx`:
- Line 8: Update the RadioCard import in index.test.tsx to use the project’s
absolute `@nemo/common` alias targeting the RadioCard component instead of the
relative "." path; leave the test behavior unchanged.
In `@web/packages/common/src/components/RadioCard/index.tsx`:
- Around line 101-105: Update the state selectors in the RadioCard class list to
scope both :checked and :disabled matching to the `.nv-radio-group-input`
element, preventing nested controls in the label or description from affecting
card styling. Preserve the existing checked prop styling and disabled visual
behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f6119f5a-5e5d-4f80-8515-253f4b9602af
📒 Files selected for processing (6)
web/packages/common/src/components/DataView/StudioDataView.test.tsxweb/packages/common/src/components/DataView/StudioDataViewToolbar.tsxweb/packages/common/src/components/RadioCard/RadioCard.stories.tsxweb/packages/common/src/components/RadioCard/index.test.tsxweb/packages/common/src/components/RadioCard/index.tsxweb/packages/common/src/utils/entityName.test.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- web/packages/common/src/components/DataView/StudioDataView.test.tsx
- web/packages/common/src/components/DataView/StudioDataViewToolbar.tsx
- web/packages/common/src/utils/entityName.test.ts
Signed-off-by: Octavian Drulea <odrulea@nvidia.com>
…t interfere Signed-off-by: Octavian Drulea <odrulea@nvidia.com>
steramae-nvidia
approved these changes
Aug 4, 2026
nv-odrulea
enabled auto-merge
August 4, 2026 18:25
walston
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RadioCardwith booleanshowIndicator, if false, hides radio control. Also adds border color to indicate selected card.StudioDataViewToolbar: adds row action supportentityName.test.ts: removes assertions againstsecretsCreateSecretBodyNameMax/RegExp— the secrets SDK schema dropped those named exports after regenerationRadioCard, with/without indicator
DataView bulk header, before/after this fix
Before
After
Summary by CodeRabbit
New Features
Bug Fixes
Tests